Fixed tooltips for element links #12840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cannot get the annoying tail to sit correctly. I am not even sure where it is actually supposed to go? Middle of the tooltip or middle of the element?
This comment was marked as resolved.
This comment was marked as resolved.
barklund
changed the title
|
Plugin builds for 913d571 are ready 🛎️!
|
|
Size Change: +301 B (0%) Total Size: 2.7 MB
ℹ️ View Unchanged
|
miina
approved these changes
Dec 20, 2022
barklund
commented
Dec 20, 2022
Comment on lines
+38
to
+40
| expect(withProtocol('https://foo.com/test')).toBe('https://foo.com/test'); | ||
| expect(withProtocol('http://foo.com/test')).toBe('http://foo.com/test'); | ||
| expect(withProtocol('foo.com/test')).toBe('https://foo.com/test'); |
There was a problem hiding this comment.
The only reason for this change is to make each fit on a single line because it's prettier 😂
|
Confirmed that element links attached to the following different types of elements yields favorable results with the
I also tried this on a mobile device, and desktop browsers. |
|
@swissspidy @barklund - the observation I wanted to share with you is that if I attach a link to a text element, then the tail of the tool tip is sometimes difficult to see since the color of the tool tip matches the (default) background color -- white |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is an attempt at fixing the tooltips.
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Checklist
Type: XYZlabel to the PRFixes #12834