Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom behavior broken #13222

Closed
ayushnirwal opened this issue Apr 19, 2023 · 6 comments · Fixed by #13566
Closed

Zoom behavior broken #13222

ayushnirwal opened this issue Apr 19, 2023 · 6 comments · Fixed by #13566
Labels
Group: Canvas P3 Nice to have Type: Bug Something isn't working

Comments

@ayushnirwal
Copy link
Contributor

ayushnirwal commented Apr 19, 2023

Bug Description

On a 2K display, going from Fill or 200% zoom level (with some non-zero scroll) to 100% leaves the Display layer and frames layer un aligned.

Expected Behaviour

The Display Layer should not be out of view.

Steps to Reproduce

  1. Add a few elements to the story.
  2. Set the zoom level to 200% or Fill.
  3. Scroll to the bottom of the canvas.
  4. Set the zoom level to 100% or Fill.

Screenshots

Screen.Recording.2023-04-19.at.10.38.50.AM.mov

Additional Context

  • Plugin Version: 1.32.0-alpha.0
  • WordPress Version: 6.2
  • Operating System: MacOS
  • Browser: Chrome
  • Display resolution: 2048 * 1080
@ayushnirwal ayushnirwal added the Type: Bug Something isn't working label Apr 19, 2023
@swissspidy
Copy link
Collaborator

Good catch! We should fix this

@swissspidy swissspidy added the P1 High priority, must do soon label Apr 25, 2023
@swissspidy swissspidy added this to the 1.33.0 milestone Apr 26, 2023
@swissspidy
Copy link
Collaborator

Possibly related: #7638

@swissspidy swissspidy added P2 Should do soon P3 Nice to have and removed P1 High priority, must do soon P2 Should do soon labels May 10, 2023
@swissspidy swissspidy removed this from the 1.33.0 milestone May 10, 2023
@swissspidy
Copy link
Collaborator

@AnuragVasanwala are you able to reproduce this one?

@AnuragVasanwala
Copy link
Collaborator

@AnuragVasanwala are you able to reproduce this one?

@swissspidy Yes, I tried to reproduce it and Display Layer gets out of the view. Upon adding a new element gets back Display Layer so need fix for this. Will identify the cause.

Do you suggest any pointers regarding the issue?

@swissspidy
Copy link
Collaborator

Unfortunately I don‘t have any pointers. It‘s also not a high priority issue, let‘s focus on the group layer bug first.

@AnuragVasanwala
Copy link
Collaborator

@swissspidy Just an update!

Changing false value of --overflow-y to auto (from visible) seems fixed the issue but still trying to figure out why? 🤔

'--overflow-y': hasVerticalOverflow ? 'scroll' : 'visible',

- '--overflow-y': hasVerticalOverflow ? 'scroll' : 'visible', 
+ '--overflow-y': hasVerticalOverflow ? 'scroll' : 'auto', 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Canvas P3 Nice to have Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants