Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safezone makes canvas too big; hides page menu and carousel #1467

Closed
swissspidy opened this issue May 4, 2020 · 5 comments · Fixed by #1553
Closed

Safezone makes canvas too big; hides page menu and carousel #1467

swissspidy opened this issue May 4, 2020 · 5 comments · Fixed by #1553
Assignees
Labels
Group: Canvas P0 Critical, drop everything Type: Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

Bug Description

Caused by #1310.
See #1244.
See #1245.

Expected Behaviour

Due to the safe zone that is being displayed above and below the page, the canvas pushes down the carousel, and makes it practically invisible on a "smaller" screen (tested on 15 inch MBP).

Steps to Reproduce

  1. Open editor
  2. Notice partially hidden page menu
  3. Notice hidden carousel

Screenshots

Screenshot 2020-05-04 at 13 17 24


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@swissspidy swissspidy added Type: Bug Something isn't working P0 Critical, drop everything Group: Canvas labels May 4, 2020
@swissspidy
Copy link
Collaborator Author

cc @wassgha

@dvoytenko dvoytenko assigned wassgha and unassigned jauyong May 4, 2020
@wassgha
Copy link
Contributor

wassgha commented May 4, 2020

Hmm @dvoytenko did this happen before on 16:9?

@dvoytenko
Copy link
Contributor

/to @wassgha let's address right away while it's fresh.

@dvoytenko
Copy link
Contributor

dvoytenko commented May 4, 2020

Not that I know of, it did some measurements/calculations to ensure min-height.

@dvoytenko
Copy link
Contributor

To correct my statement: there's a min-max calculation in the canvas/layout.js to avoid this issue specifically. My guess, simply, it needs to be adjusted for the new aspect ratio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Canvas P0 Critical, drop everything Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants