Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes editor resizing after fullbleed #1553

Merged
merged 1 commit into from May 6, 2020
Merged

Fixes editor resizing after fullbleed #1553

merged 1 commit into from May 6, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented May 5, 2020

Closes #1467

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #1553 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1553   +/-   ##
=========================================
  Coverage     57.66%   57.66%           
  Complexity      215      215           
=========================================
  Files           527      527           
  Lines          8695     8695           
=========================================
  Hits           5014     5014           
  Misses         3681     3681           
Impacted Files Coverage Δ Complexity Δ
assets/src/edit-story/components/canvas/layout.js 65.00% <0.00%> (ø) 0.00 <0.00> (ø)

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2020

Size Change: +2 B (0%)

Total Size: 817 kB

Filename Size Change
assets/js/edit-story.js 396 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 3.04 kB 0 B
assets/css/stories-dashboard.css 3.04 kB 0 B
assets/js/stories-dashboard.js 415 kB 0 B

compressed-size-action

@swissspidy swissspidy added Group: Canvas Type: Bug Something isn't working labels May 5, 2020
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for me!

Screenshot 2020-05-05 at 17 33 29

@swissspidy swissspidy merged commit 77601a2 into master May 6, 2020
@swissspidy swissspidy deleted the fix/safezone branch May 6, 2020 15:46
obetomuniz added a commit that referenced this pull request May 6, 2020
* master: (53 commits)
  Inline text formatting (#1323)
  Bump terser-webpack-plugin from 2.3.6 to 3.0.1 (#1597)
  Allow disabling warning on exit in development (#1176)
  fixing indent that was missed by automation
  Deploy plugin bundle to wiki repo for easier QA (#1590)
  Fix initial height of preset panel (#1591)
  Fixes editor resizing after fullbleed (#1553)
  More error handling
  Fix file drag & drop crash for unsupported media types (#1431)
  Improve test
  Bump polished from 3.6.1 to 3.6.2 (#1577)
  Bump react-transition-group from 4.3.0 to 4.4.0 (#1565)
  Remove Delete Page shortcut tooltip (#1574)
  renaming filteredStories to just stories. they are not filtered.
  updating typeahead input and options for new designs. New colors, tighter space, different expanded view. Removing option to filter internally through typeahead since we do all of that outside of the component. some styled component cleanup
  Remove wp element.
  Bump @testing-library/dom from 7.2.2 to 7.3.0 (#1563)
  Remove wp element
  Lints in tests
  Add more tests
  ...
obetomuniz added a commit that referenced this pull request May 6, 2020
* master: (109 commits)
  Inline text formatting (#1323)
  Bump terser-webpack-plugin from 2.3.6 to 3.0.1 (#1597)
  Allow disabling warning on exit in development (#1176)
  fixing indent that was missed by automation
  Deploy plugin bundle to wiki repo for easier QA (#1590)
  Fix initial height of preset panel (#1591)
  Fixes editor resizing after fullbleed (#1553)
  More error handling
  Fix file drag & drop crash for unsupported media types (#1431)
  Improve test
  Bump polished from 3.6.1 to 3.6.2 (#1577)
  Bump react-transition-group from 4.3.0 to 4.4.0 (#1565)
  Remove Delete Page shortcut tooltip (#1574)
  renaming filteredStories to just stories. they are not filtered.
  updating typeahead input and options for new designs. New colors, tighter space, different expanded view. Removing option to filter internally through typeahead since we do all of that outside of the component. some styled component cleanup
  Remove wp element.
  Bump @testing-library/dom from 7.2.2 to 7.3.0 (#1563)
  Remove wp element
  Lints in tests
  Add more tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Canvas Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safezone makes canvas too big; hides page menu and carousel
3 participants