Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Optimization: MOV placeholder element position wrong #7839

Closed
swissspidy opened this issue Jun 7, 2021 · 1 comment · Fixed by #7891
Closed

Video Optimization: MOV placeholder element position wrong #7839

swissspidy opened this issue Jun 7, 2021 · 1 comment · Fixed by #7891
Labels
Group: Media Group: Video Optimization Media transcoding, compression and cropping P2 Should do soon Type: Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

Bug Description

When dropping an MOV file into the editor, the video dimensions are not yet known. So we display a placeholder element in the center of the canvas.

However, this initial positioning seems to have broken recently, as in, it is not centered anymore. Perhaps with the introduction of zooming?

Expected Behaviour

The placeholder element should not be displayed off-canvas.

The position should match the one from #7766.

Steps to Reproduce

  1. Drop MOV file into editor
  2. See how the placeholder is positioned partly off-canvas

Screenshots

Position off canvas:

Screenshot 2021-06-07 at 11 55 02

In #6541 it looked like this:

Screenshot 2021-06-07 at 12 00 49

Additional Context

  • Plugin Version: 1.7
  • WordPress Version: 5.7
  • Operating System: macOS
  • Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

  • This probably needs updating in useUploadWithPreview.js
@swissspidy swissspidy added Type: Bug Something isn't working Group: Media P2 Should do soon Pod: WP & Infra Group: Video Optimization Media transcoding, compression and cropping labels Jun 7, 2021
@csossi
Copy link

csossi commented Jun 13, 2021

Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Media Group: Video Optimization Media transcoding, compression and cropping P2 Should do soon Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants