Media: Transcode videos inserted from WordPress media modal #7766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Enhancement
spacedmonkey
commented
May 28, 2021
spacedmonkey
commented
May 28, 2021
| @@ -17,25 +17,3 @@ | |||
| const GB_IN_BYTES = 1024 * 1024 * 1024; | |||
|
|
|||
| export const MEDIA_TRANSCODING_MAX_FILE_SIZE = 2 * GB_IN_BYTES; | |||
|
|
|||
There was a problem hiding this comment.
Moved to PHP and values come from config provider now.
spacedmonkey
commented
May 28, 2021
spacedmonkey
commented
May 28, 2021
includes/Integrations/Jetpack.php
Outdated
Comment on lines
135
to
140
| if ( ! array_diff( $allowed_mime_types, $args['post_mime_type'] ) ) { | ||
| add_filter( 'wp_prepare_attachment_for_js', [ $this, 'filter_admin_ajax_response' ], 10, 2 ); | ||
| } | ||
| if ( ! array_diff( $allowed_mime_types_transcodable, $args['post_mime_type'] ) ) { | ||
| add_filter( 'wp_prepare_attachment_for_js', [ $this, 'filter_admin_ajax_response' ], 10, 2 ); | ||
| } |
There was a problem hiding this comment.
It is impossible to know if transcoding is possible as this is at broswer level. So check, with and without transcodable mime types.
spacedmonkey
commented
May 28, 2021
spacedmonkey
commented
May 28, 2021
Comment on lines
188
to
192
| const transcodableMimeTypes = useMemo(() => { | ||
| return allowedAllowedTranscodableTypes.filter( | ||
| (x) => !allowedVideoMimeTypes.includes(x) | ||
| ); | ||
| }, [allowedAllowedTranscodableTypes, allowedVideoMimeTypes]); |
There was a problem hiding this comment.
Remove video/mp4 and video/webm from list of transcodable mime types here. We don't need to do anything special for these file types, they should just work.
|
Size Change: +651 B (0%) Total Size: 2.12 MB
ℹ️ View Unchanged
|
spacedmonkey
commented
May 28, 2021
Comment on lines
+167
to
+171
| if ( | ||
| enableMediaPickerVideoOptimization && | ||
| isFeatureEnabled && | ||
| isTranscodingEnabled | ||
| ) { |
There was a problem hiding this comment.
If transcoding is supported, then add transcodable mime types to list of allowed types in the media picker.
spacedmonkey
commented
May 28, 2021
spacedmonkey
commented
May 28, 2021
Comment on lines
+148
to
+150
| updateExistingElements({ | ||
| oldResource: oldResourceWithId, | ||
| }); |
There was a problem hiding this comment.
Updating the resource like this, means src is set empty, making it not playable, which is what we want.
spacedmonkey
commented
May 28, 2021
10 tasks
…into try/transcode-mov
Codecov Report
@@ Coverage Diff @@
## main #7766 +/- ##
==========================================
- Coverage 84.20% 80.32% -3.88%
==========================================
Files 1161 1291 +130
Lines 17574 22891 +5317
==========================================
+ Hits 14798 18387 +3589
- Misses 2776 4504 +1728
Flags with carried forward coverage won't be shown. Click here to find out more.
|
swissspidy
reviewed
Jun 2, 2021
| @@ -219,7 +216,7 @@ function useFFmpeg() { | |||
| * @return {boolean} Whether transcoding is likely possible. | |||
| */ | |||
| const canTranscodeFile = (file) => | |||
| MEDIA_TRANSCODING_SUPPORTED_INPUT_TYPES.includes(file.type); | |||
| allowedAllowedTranscodableTypes.includes(file.type); | |||
There was a problem hiding this comment.
This comes from config object on the page. This is long / horrible name because I wanted it to describe the value.
This the current config object.
Wonder if mime types should look more like this.
We could also do a similar refactor file types / ext.
This is a large refactor, that would effect lot of other parts of the code, including fixture for tests etc. Willing to look into this and even add to this PR.
There was a problem hiding this comment.
Can we use allowedTranscodableTypes for now? Or even allowedTranscodableMimeTypes?
But allowedAllowed is just duplicated 🤔
There was a problem hiding this comment.
🤦 I thought you had a problem with the name. I didn't even notice the allowedAllowed. My brain would not let me see it. I will change.
My point stands able the messy config.
swissspidy
reviewed
Jun 2, 2021
| } from '@web-stories-wp/e2e-test-utils'; | ||
|
|
||
| const MODAL = '.media-modal'; | ||
|
|
||
| describe('Inserting .mov from dialog', () => { | ||
| withExperimentalFeatures(['enableMediaPickerVideoOptimization']); |
There was a problem hiding this comment.
We'd need two tests here.
One with experiment enabled, one without the experiment.
This way we know there's no regression introduced by this.
There was a problem hiding this comment.
Yeah, I changed the test late last night and this was going to something I changed back this morning. We will still need to make sure that mov are filters for users that do not enable / support transcoding.
swissspidy
reviewed
Jun 2, 2021
includes/Integrations/Jetpack.php
Outdated
| add_filter( 'wp_prepare_attachment_for_js', [ $this, 'filter_admin_ajax_response' ], 15, 2 ); | ||
| $allowed_mime_types = $this->get_allowed_mime_types(); | ||
| $allowed_mime_types = array_merge( ...array_values( $allowed_mime_types ) ); | ||
| $allowed_mime_types_transcodable = array_merge( $allowed_mime_types, $this->get_allow_transcodable_mime_types() ); |
There was a problem hiding this comment.
This appears to be the only reason why get_allow_transcodable_mime_types is needed in PHP, is that correct? And it's only needed here to determine whether the ajax request is coming from our editor?
There was a problem hiding this comment.
Yeah, I did not want to maintain two lists here. I also think this is a example of a where this value should be populated from PHP, so it maybe needed in other context in the future in PHP.
swissspidy
reviewed
Jun 2, 2021
swissspidy
reviewed
Jun 2, 2021
assets/src/edit-story/components/library/panes/media/local/mediaPane.js
Outdated
Show resolved
Hide resolved
swissspidy
reviewed
Jun 2, 2021
swissspidy
reviewed
Jun 2, 2021
spacedmonkey
commented
Jun 2, 2021
swissspidy
approved these changes
Jun 7, 2021
This was referenced Jun 7, 2021
merapi
added a commit
that referenced
this pull request
Jun 21, 2021
commit 7e3eb21 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 16:04:35 2021 +0100 Bump WP requirement in plugin (#7926) * Change min version 5.5 * Only install gutenberg on latest version. commit 3079998 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 15:10:59 2021 +0100 PHP: Remove WP <5.5 compatibility code (#7951) * Remove pre 5.5 back compat. * Force bool. commit dc9e4bc Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 13:38:38 2021 +0100 Bump PHP requirement in plugin (#7949) * Change min version to 7.0 * Fix comment. commit 4b26ad9 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 12:39:50 2021 +0100 Change version of CI run PHP. (#7946) commit 9ba4d2c Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Fri Jun 18 13:30:23 2021 -0700 new set of constants based on existing prepublish checklist but reorganized for easier use in new structure. Pending confirmation of using existing helper (footer) copy. All lists are in fragments so that we can keep the styled list closer to the components. A11y checks: fontSizeTooSmall, imagesMissingAltText, linkTappableRegionTooSmall, lowContrast, videoMissingCaptions, videoMissingTitle. Design checks: storyTooShort, storyTooLong, tooLittlePageText, tooMuchPageText, tooManyLinksOnPage, lowImageResolution, videoFrameRateTooLow, videoResolutionTooLow, videoResolutionTooHigh. Priority checks: storyMissingDescription, storyMissingTitle, storyMissingPoster, videoMissingPoster, storyTitleTooLong, logoTooSmall, posterTooSmall, storyPosterWrongRatio, videonotOptimized (#7988) commit 3eb0800 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Fri Jun 18 12:47:21 2021 -0400 Add snackbar text (#7972) commit 52e6190 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Fri Jun 18 12:47:01 2021 -0400 Add docs (#7975) commit 50a0225 Author: Miina <miina.sikk@gmail.com> Date: Fri Jun 18 10:18:40 2021 +0300 Fix JSX accessibility issues (#7955) * Remove some incorrect handlers. * Allow tabIndex. * Revert change. * Change textset to button. * Adjustments. * Panel handle. * Comment * Add back text edit logic. * Try without mouseDown * Remove test relying on incorrect aria selector. * Improvements. * Adjust text editor logic. * Karma * Add comment. commit 6205ae3 Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Thu Jun 17 13:21:48 2021 -0700 PPC: Single Issue Card Component (#7967) * WIP cards * wip cards, pending rest of a11y * organize better * add hover on card, this is going to need updating because it makes CTA bg disappear. pending design input. secondary and teriary button types have this same issue. * "pointer" :p * my own nits * rename helper to footer * make card styles accessible should we want them isolated * move list wrapper to be with styles now that all styles get exported just makes more sense * fix reorganization linting error * proof of concept on multiple issue cards working in grid. * clean up multi issue, some lingering a11y things to noodle but the structure is here. * little clean up * kill the card hover bg color * make default components for cta and footer to avoid redundant set up commit 823cd1a Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Thu Jun 17 17:17:21 2021 +0100 Don't generate square and landscape poster images (#7947) * Remove square and landscape image sizes. * Fix lint. * Remove todo. * Remove references in edit story. * Remove unneeded test data. commit 01cc3ab Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jun 17 09:32:18 2021 +0400 Migrate templates and text sets to latest version (#7948) Co-authored-by: swissspidy <swissspidy@users.noreply.github.com> commit 087af87 Author: choumx <choumx@users.noreply.github.com> Date: Wed Jun 16 17:04:53 2021 +0000 Post-release version bump commit a138bd0 Author: choumx <choumx@users.noreply.github.com> Date: Wed Jun 16 17:00:34 2021 +0000 Prepare release 1.8.0 commit 0d62845 Author: William Chou <willchou@google.com> Date: Wed Jun 16 12:54:22 2021 -0400 Update readme.txt for 1.8.0. (#7963) commit 46b18f8 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Wed Jun 16 15:28:06 2021 +0100 Video Optimization: MOV placeholder element position wrong (#7891) * Use default values on insert. * Remove unused const. commit 96ceba3 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Wed Jun 16 09:46:30 2021 +0100 Packages: Move media to new structure (#7954) * Move logic to new media utils package. * Change package name. * Update react. * Fix import. * Move getFocalFromOffset * Update lock file * Remove comment. * Only pick bits we need. * Revery getMediaBaseColor change. * Revert useAverageColor change. * Revert get file name util. * Update lock file. * Update lock file. commit 73cac9a Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Tue Jun 15 15:56:16 2021 -0500 PPC Video Optimization: Thumbnail Support in Snacks (#7957) commit 2a408fe Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Tue Jun 15 13:14:58 2021 -0700 Prepublish Checklist: Thumbnail Component (#7953) * thumbnail basics * new gear icon * fix import order * nits, fix eslint prop expectation commit 1302fbc Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Tue Jun 15 11:12:09 2021 -0600 Right Click Menu: Implementation Proposal (#7850) commit 4121f0f Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 15 15:14:32 2021 +0100 Packages: Move `units` to new structure (#7895) * Packages: Move `units` to new structure * Add readme.md * Stop redefining consts. * Remove dependency. * Remove dependency. * Use FULLBLEED_HEIGHT const. * Break into another file. * Fix comments. * Fix lint. * Fix lock file * Move isElementBelowLimit. commit fc6726f Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Mon Jun 14 10:53:46 2021 -0500 Accessibility: Keyboard Shortcuts Menu Accessibility and I18N Improvements (#7911) * working translatable strings * fix ctrl key width commit 87fd694 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 14 13:19:42 2021 +0300 Add date to fixture, too. (#7924) commit 618c78c Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Fri Jun 11 13:24:40 2021 -0700 Right Click Menus: UI prep (#7873) * storybook for right click menus to start looking at overlap and structure. Possible demo of dismissing menus all the time for everything. Adding ariaLabel to context menu, if present use that for aria-label of menu items, otherwise just use the visible label (there are a few new actions on these menus that could use a bit more description for non visual users * singular "style" usage for copy paste clear for all menus that have those options per copy update from Omar * one idea of how to handle menu positioning. * clean up * use kbd for shortcuts in context menu * fix 7897 while im in the context menu component * avoid nesting aria labels. use sprintf instead to consolidate a11y text. * small cleanup commit 7d1f176 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Fri Jun 11 12:03:05 2021 -0600 Quick Action Menu: Change background color opens the page background panel if it is collapsed (#7868) commit 2719019 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Fri Jun 11 17:04:53 2021 +0100 Unpin composer version in CI. (#7929) commit 00892bf Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Fri Jun 11 13:46:41 2021 +0100 Packages: Move `patterns` to new structure (#7910) * Move files to pattern package. * Handle prop types * Mocking. * Fix mocking. * More fixing. * Skip test for now * Better mocks * Only mock the necessary function. * Use requireActual. * Feedback. Co-authored-by: Miina Sikk <miina.sikk@gmail.com> commit bb73178 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:02:52 2021 +0200 Bump eslint from 7.27.0 to 7.28.0 (#7859) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pascal Birchler <pascalb@google.com> commit 8914eaa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:02:44 2021 +0200 Bump @wordpress/jest-puppeteer-axe from 3.0.4 to 3.0.5 (#7905) Bumps [@wordpress/jest-puppeteer-axe](https://github.com/WordPress/gutenberg/tree/HEAD/packages/jest-puppeteer-axe) from 3.0.4 to 3.0.5. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/jest-puppeteer-axe/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/jest-puppeteer-axe@3.0.5/packages/jest-puppeteer-axe) --- updated-dependencies: - dependency-name: "@wordpress/jest-puppeteer-axe" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 81fe907 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:02:22 2021 +0200 Bump core-js from 3.13.0 to 3.14.0 (#7904) Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.13.0 to 3.14.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.14.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6022448 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:01:44 2021 +0200 Bump @ampproject/toolbox-optimizer from 2.7.6 to 2.8.0 (#7902) Bumps [@ampproject/toolbox-optimizer](https://github.com/ampproject/amp-toolbox/tree/HEAD/packages/optimizer) from 2.7.6 to 2.8.0. - [Release notes](https://github.com/ampproject/amp-toolbox/releases) - [Changelog](https://github.com/ampproject/amp-toolbox/blob/main/CHANGELOG.md) - [Commits](https://github.com/ampproject/amp-toolbox/commits/v2.8.0/packages/optimizer) --- updated-dependencies: - dependency-name: "@ampproject/toolbox-optimizer" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 07d7057 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:01:34 2021 +0200 Bump @wordpress/eslint-plugin from 9.0.2 to 9.0.6 (#7901) Bumps [@wordpress/eslint-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin) from 9.0.2 to 9.0.6. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/eslint-plugin@9.0.6/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@wordpress/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 263f5ca Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:01:27 2021 +0200 Bump @babel/preset-env from 7.14.2 to 7.14.4 (#7900) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.2 to 7.14.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.4/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0455e2a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 20:59:47 2021 +0200 Bump jest from 27.0.3 to 27.0.4 (#7899) Bumps [jest](https://github.com/facebook/jest) from 27.0.3 to 27.0.4. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v27.0.3...v27.0.4) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 5c01b1c Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 18:57:42 2021 +0200 Output: Preload the first page’s background media (#7505) commit 2375895 Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 12:24:14 2021 +0200 Fix some JSDoc warnings commit 2ba0527 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Wed Jun 9 11:18:06 2021 +0100 Completely remove enabled experiment code (#7888) commit 6ebb7e1 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:17:05 2021 +0200 Bump @wordpress/block-editor from 6.1.0 to 6.1.3 (#7880) Bumps [@wordpress/block-editor](https://github.com/WordPress/gutenberg/tree/HEAD/packages/block-editor) from 6.1.0 to 6.1.3. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/block-editor@6.1.3/packages/block-editor) --- updated-dependencies: - dependency-name: "@wordpress/block-editor" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c82d47f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:16:58 2021 +0200 Bump rollup from 2.51.0 to 2.51.1 (#7883) Bumps [rollup](https://github.com/rollup/rollup) from 2.51.0 to 2.51.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.51.0...v2.51.1) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 75ac447 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:03:24 2021 +0200 Bump @wordpress/jest-console from 4.0.4 to 4.0.5 (#7886) Bumps [@wordpress/jest-console](https://github.com/WordPress/gutenberg/tree/HEAD/packages/jest-console) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/jest-console@4.0.5/packages/jest-console) --- updated-dependencies: - dependency-name: "@wordpress/jest-console" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f3b04f8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:02:34 2021 +0200 Bump jest-axe from 4.1.0 to 5.0.1 (#7882) Bumps [jest-axe](https://github.com/nickcolley/jest-axe) from 4.1.0 to 5.0.1. - [Release notes](https://github.com/nickcolley/jest-axe/releases) - [Changelog](https://github.com/nickcolley/jest-axe/blob/main/CHANGELOG.md) - [Commits](https://github.com/nickcolley/jest-axe/commits) --- updated-dependencies: - dependency-name: jest-axe dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit bbd6897 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:02:18 2021 +0200 Bump @wordpress/dom-ready from 3.1.0 to 3.1.1 (#7881) Bumps [@wordpress/dom-ready](https://github.com/WordPress/gutenberg/tree/HEAD/packages/dom-ready) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/dom-ready/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/dom-ready@3.1.1/packages/dom-ready) --- updated-dependencies: - dependency-name: "@wordpress/dom-ready" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c43362e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:02:12 2021 +0200 Bump axe-core from 4.2.1 to 4.2.2 (#7879) Bumps [axe-core](https://github.com/dequelabs/axe-core) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md) - [Commits](dequelabs/axe-core@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: axe-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit aaa3f7b Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:40:00 2021 +0200 Only run add-milestone action for main branch commit cdbf01c Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:37:57 2021 +0200 AMP: De-duplicate inline styles (#7743) Co-authored-by: Weston Ruter <westonruter@google.com> commit 5ead926 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:24:51 2021 +0200 Bump eslint-plugin-jsdoc from 35.0.0 to 35.1.3 (#7855) Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 35.0.0 to 35.1.3. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v35.0.0...v35.1.3) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 603fbdd Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:17:29 2021 +0200 Templates: add test for videos with `isOptimized` Template assets loaded from the CDN are always optimized commit 3c19e3c Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:12:33 2021 +0200 Fix typo in test commit 180564d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:56 2021 +0200 Bump @testing-library/jest-dom from 5.12.0 to 5.13.0 (#7861) Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.12.0 to 5.13.0. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v5.12.0...v5.13.0) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 020e177 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:49 2021 +0200 Bump @wordpress/viewport from 3.1.0 to 3.1.1 (#7860) Bumps [@wordpress/viewport](https://github.com/WordPress/gutenberg/tree/HEAD/packages/viewport) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/viewport/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/viewport@3.1.1/packages/viewport) --- updated-dependencies: - dependency-name: "@wordpress/viewport" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 564a364 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:41 2021 +0200 Bump @wordpress/blocks from 9.1.1 to 9.1.2 (#7858) Bumps [@wordpress/blocks](https://github.com/WordPress/gutenberg/tree/HEAD/packages/blocks) from 9.1.1 to 9.1.2. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/blocks@9.1.2/packages/blocks) --- updated-dependencies: - dependency-name: "@wordpress/blocks" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6fa0ff7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:35 2021 +0200 Bump polished from 4.1.2 to 4.1.3 (#7857) Bumps [polished](https://github.com/styled-components/polished) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/styled-components/polished/releases) - [Commits](styled-components/polished@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: polished dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 54ec5b2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:26 2021 +0200 Bump @wordpress/dependency-extraction-webpack-plugin from 3.1.2 to 3.1.4 (#7856) Bumps [@wordpress/dependency-extraction-webpack-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/dependency-extraction-webpack-plugin) from 3.1.2 to 3.1.4. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/dependency-extraction-webpack-plugin@3.1.4/packages/dependency-extraction-webpack-plugin) --- updated-dependencies: - dependency-name: "@wordpress/dependency-extraction-webpack-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a608974 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:00 2021 +0200 Bump cssnano from 5.0.4 to 5.0.5 (#7853) Bumps [cssnano](https://github.com/cssnano/cssnano) from 5.0.4 to 5.0.5. - [Release notes](https://github.com/cssnano/cssnano/releases) - [Commits](https://github.com/cssnano/cssnano/compare/cssnano@5.0.4...cssnano@5.0.5) --- updated-dependencies: - dependency-name: cssnano dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 53565e5 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:03:53 2021 +0200 Bump prettier from 2.3.0 to 2.3.1 (#7854) Bumps [prettier](https://github.com/prettier/prettier) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.3.0...2.3.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 83084dc Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Tue Jun 8 17:13:20 2021 -0600 Quick action menu: Remove feature flag (#7795) commit 5e5789d Author: Pascal Birchler <pascalb@google.com> Date: Tue Jun 8 18:53:16 2021 +0200 Fix equal sign alignment in unit test commit f7dcc8b Author: Pascal Birchler <pascalb@google.com> Date: Tue Jun 8 18:44:29 2021 +0200 Workflow: Add GitHub action for tagging PRs with releases (#7796) commit ecd2c12 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 16:54:58 2021 +0100 E2E Tests: fix user creation and switching (#7803) Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> Co-authored-by: Pascal Birchler <pascalb@google.com> commit c4837c6 Author: Pascal Birchler <pascalb@google.com> Date: Tue Jun 8 15:20:06 2021 +0200 Composer: remove `—no-suggest` option (#7864) This option is deprecated in Composer v2 commit 10b40b7 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 13:29:35 2021 +0100 Force composer 2.1.1 (#7863) commit df6695b Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 12:21:34 2021 +0100 Media: Mark 3P Media resources as optimized (#7847) commit 0971a88 Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 11:53:52 2021 +0300 Fix date resetting. (#7852) commit 18c9e36 Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 10:36:56 2021 +0300 Fix entering edit mode via click for Safari (#7782) * Remove using deprecated method that works incorrectly. * Add an alternative approach to keep caretRangeFromPoint in. * Add Safari fix * Remove redundant true. commit b16c9f5 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 07:56:18 2021 +0100 Media: Transcode videos inserted from WordPress media modal (#7766) commit 974ff65 Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 09:30:31 2021 +0300 Fix colour picker focus styles. (#7801) commit 2c70b6a Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 09:29:35 2021 +0300 Allow publishing stories "Immediately" (#7759) * Add the floating date logic. * Add reset date button. * Add unit test. * Replace some colours. * revert some color changes. * Nit * Keep poster when combining elements. * Revert commit. * Fix empty input issue. commit b801d43 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Mon Jun 7 12:57:32 2021 -0600 Right Click Menu: add feature flag (#7848) commit f554015 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 20:56:34 2021 +0200 Enable AMP ESM transformation once again (#7845) Reverts #7521 and #7749 commit a3a6538 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 21:50:12 2021 +0300 Avoid excess classes in preview mode (#7815) commit c0a0444 Author: Emily Bartman <emily.bartman@formidable.com> Date: Mon Jun 7 11:28:19 2021 -0700 Fix Karma Clear Animation & Undo Tests (#7820) * consolidate clear buttons into one * add style resets for opacity, border, radius. mostly copy from 7771 * WIP - seems the issues from 771 have followed us here and karma is only failing remote even when run headless! pushing up to run in CI to confirm suspicions. * WIP - adding additional check for clear button and a sleep to see if this passes remotely. Fixing a prop type that clutters the console when running tests * add a check for default border radius specific to text element since that is different from everything else. * rebase catch up * fix: karma tests for clearing animations and filters on elements quick actions Co-authored-by: Brittany Feenstra <brittany.feenstra@formidable.com> commit 6c8b2ad Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 19:35:18 2021 +0200 Fix incorrect publish time handling (#7800) commit 5132c07 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 19:34:53 2021 +0200 Links: remove empty data attributes (#7806) commit 1222255 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 15:51:54 2021 +0200 Bump puppeteer from 9.1.1 to 10.0.0 (#7835) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pascal Birchler <pascalb@google.com> commit 1789834 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 14:26:33 2021 +0200 Update PHPUnit workflow (#7816) commit 1c3ab77 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jun 7 14:26:06 2021 +0200 Migrate templates and text sets (#7841) Co-authored-by: swissspidy <swissspidy@users.noreply.github.com> commit b4a7c67 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 13:15:20 2021 +0200 Use custom video poster instead of default when available. (#7827) Co-authored-by: Pascal Birchler <pascalb@google.com> commit f8ca0ff Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 7 11:06:09 2021 +0100 Analytics: Update message when Site Kit is installed (#7701) Co-authored-by: Pascal Birchler <pascalb@google.com> commit c173c62 Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Mon Jun 7 04:42:37 2021 -0500 Animation: Fixed Delta for Background Zoom Animations (#7817) commit 4b896f6 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 11:36:57 2021 +0200 Animations: honor `prefers-reduced-motion` setting (#7601) commit bdacadd Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Mon Jun 7 04:35:24 2021 -0500 Bug: Fix Help Center Links (#7829) commit 51d9210 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:30:19 2021 +0200 Bump @testing-library/dom from 7.31.0 to 7.31.2 (#7834) Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.31.0 to 7.31.2. - [Release notes](https://github.com/testing-library/dom-testing-library/releases) - [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/dom-testing-library@v7.31.0...v7.31.2) --- updated-dependencies: - dependency-name: "@testing-library/dom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9061bc1 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:30:09 2021 +0200 Bump @wordpress/blocks from 9.1.0 to 9.1.1 (#7833) Bumps [@wordpress/blocks](https://github.com/WordPress/gutenberg/tree/HEAD/packages/blocks) from 9.1.0 to 9.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/blocks/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/blocks@9.1.1/packages/blocks) --- updated-dependencies: - dependency-name: "@wordpress/blocks" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c06d9c0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:29:48 2021 +0200 Bump @wordpress/e2e-test-utils from 5.2.0 to 5.3.0 (#7832) Bumps [@wordpress/e2e-test-utils](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils) from 5.2.0 to 5.3.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-test-utils/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/e2e-test-utils@5.3.0/packages/e2e-test-utils) --- updated-dependencies: - dependency-name: "@wordpress/e2e-test-utils" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2642a98 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:27:29 2021 +0200 Bump react-modal from 3.13.1 to 3.14.2 (#7837) Bumps [react-modal](https://github.com/reactjs/react-modal) from 3.13.1 to 3.14.2. - [Release notes](https://github.com/reactjs/react-modal/releases) - [Changelog](https://github.com/reactjs/react-modal/blob/master/CHANGELOG.md) - [Commits](reactjs/react-modal@v3.13.1...v3.14.2) --- updated-dependencies: - dependency-name: react-modal dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 97567a8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:27:21 2021 +0200 Bump @wordpress/url from 3.1.0 to 3.1.1 (#7830) Bumps [@wordpress/url](https://github.com/WordPress/gutenberg/tree/HEAD/packages/url) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/url/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/url@3.1.1/packages/url) --- updated-dependencies: - dependency-name: "@wordpress/url" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4cdc66e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:27:13 2021 +0200 Bump rollup from 2.50.3 to 2.51.0 (#7836) Bumps [rollup](https://github.com/rollup/rollup) from 2.50.3 to 2.51.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.50.3...v2.51.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2dcdf57 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:26:42 2021 +0200 Bump karma from 6.3.2 to 6.3.3 (#7831) Bumps [karma](https://github.com/karma-runner/karma) from 6.3.2 to 6.3.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v6.3.2...v6.3.3) --- updated-dependencies: - dependency-name: karma dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit fbc6397 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 08:13:53 2021 +0200 Always use full size for moveable. (#7814) commit 2fa2cad Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Sun Jun 6 18:01:16 2021 -0500 new defaults for rotate in animation (#7720) commit fc38c6e Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Thu Jun 3 14:18:02 2021 -0700 add disable reasons to places where jsx linting is ignored. remove old flakey test that is skipped. (#7808) commit c9214ca Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Thu Jun 3 14:16:57 2021 -0700 Quick Action Menus: Reset element (#7809) * consolidate clear buttons into one * add style resets for opacity, border, radius. mostly copy from 7771 * WIP - seems the issues from 771 have followed us here and karma is only failing remote even when run headless! pushing up to run in CI to confirm suspicions. * WIP - adding additional check for clear button and a sleep to see if this passes remotely. Fixing a prop type that clutters the console when running tests * add a check for default border radius specific to text element since that is different from everything else. * rebase catch up commit 4be0072 Author: Emily Bartman <emily.bartman@formidable.com> Date: Thu Jun 3 12:42:39 2021 -0700 Quick Action Menu: Video Element (#7811) * quick actions: video selected * skip flaky tests * ...but actually skip them * skip didn't work delete for now--will address in a future PR commit 9a4906d Author: Pascal Birchler <pascalb@google.com> Date: Thu Jun 3 00:42:29 2021 +0200 Fix typo in lint workflow
9 tasks
miina
added a commit
that referenced
this pull request
Jul 8, 2021
* Eyedropper v0 * srcSet disabled just for now * Rename zoom->magnifier * Squashed commit of the following: commit 7e3eb21 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 16:04:35 2021 +0100 Bump WP requirement in plugin (#7926) * Change min version 5.5 * Only install gutenberg on latest version. commit 3079998 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 15:10:59 2021 +0100 PHP: Remove WP <5.5 compatibility code (#7951) * Remove pre 5.5 back compat. * Force bool. commit dc9e4bc Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 13:38:38 2021 +0100 Bump PHP requirement in plugin (#7949) * Change min version to 7.0 * Fix comment. commit 4b26ad9 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 21 12:39:50 2021 +0100 Change version of CI run PHP. (#7946) commit 9ba4d2c Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Fri Jun 18 13:30:23 2021 -0700 new set of constants based on existing prepublish checklist but reorganized for easier use in new structure. Pending confirmation of using existing helper (footer) copy. All lists are in fragments so that we can keep the styled list closer to the components. A11y checks: fontSizeTooSmall, imagesMissingAltText, linkTappableRegionTooSmall, lowContrast, videoMissingCaptions, videoMissingTitle. Design checks: storyTooShort, storyTooLong, tooLittlePageText, tooMuchPageText, tooManyLinksOnPage, lowImageResolution, videoFrameRateTooLow, videoResolutionTooLow, videoResolutionTooHigh. Priority checks: storyMissingDescription, storyMissingTitle, storyMissingPoster, videoMissingPoster, storyTitleTooLong, logoTooSmall, posterTooSmall, storyPosterWrongRatio, videonotOptimized (#7988) commit 3eb0800 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Fri Jun 18 12:47:21 2021 -0400 Add snackbar text (#7972) commit 52e6190 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Fri Jun 18 12:47:01 2021 -0400 Add docs (#7975) commit 50a0225 Author: Miina <miina.sikk@gmail.com> Date: Fri Jun 18 10:18:40 2021 +0300 Fix JSX accessibility issues (#7955) * Remove some incorrect handlers. * Allow tabIndex. * Revert change. * Change textset to button. * Adjustments. * Panel handle. * Comment * Add back text edit logic. * Try without mouseDown * Remove test relying on incorrect aria selector. * Improvements. * Adjust text editor logic. * Karma * Add comment. commit 6205ae3 Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Thu Jun 17 13:21:48 2021 -0700 PPC: Single Issue Card Component (#7967) * WIP cards * wip cards, pending rest of a11y * organize better * add hover on card, this is going to need updating because it makes CTA bg disappear. pending design input. secondary and teriary button types have this same issue. * "pointer" :p * my own nits * rename helper to footer * make card styles accessible should we want them isolated * move list wrapper to be with styles now that all styles get exported just makes more sense * fix reorganization linting error * proof of concept on multiple issue cards working in grid. * clean up multi issue, some lingering a11y things to noodle but the structure is here. * little clean up * kill the card hover bg color * make default components for cta and footer to avoid redundant set up commit 823cd1a Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Thu Jun 17 17:17:21 2021 +0100 Don't generate square and landscape poster images (#7947) * Remove square and landscape image sizes. * Fix lint. * Remove todo. * Remove references in edit story. * Remove unneeded test data. commit 01cc3ab Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jun 17 09:32:18 2021 +0400 Migrate templates and text sets to latest version (#7948) Co-authored-by: swissspidy <swissspidy@users.noreply.github.com> commit 087af87 Author: choumx <choumx@users.noreply.github.com> Date: Wed Jun 16 17:04:53 2021 +0000 Post-release version bump commit a138bd0 Author: choumx <choumx@users.noreply.github.com> Date: Wed Jun 16 17:00:34 2021 +0000 Prepare release 1.8.0 commit 0d62845 Author: William Chou <willchou@google.com> Date: Wed Jun 16 12:54:22 2021 -0400 Update readme.txt for 1.8.0. (#7963) commit 46b18f8 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Wed Jun 16 15:28:06 2021 +0100 Video Optimization: MOV placeholder element position wrong (#7891) * Use default values on insert. * Remove unused const. commit 96ceba3 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Wed Jun 16 09:46:30 2021 +0100 Packages: Move media to new structure (#7954) * Move logic to new media utils package. * Change package name. * Update react. * Fix import. * Move getFocalFromOffset * Update lock file * Remove comment. * Only pick bits we need. * Revery getMediaBaseColor change. * Revert useAverageColor change. * Revert get file name util. * Update lock file. * Update lock file. commit 73cac9a Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Tue Jun 15 15:56:16 2021 -0500 PPC Video Optimization: Thumbnail Support in Snacks (#7957) commit 2a408fe Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Tue Jun 15 13:14:58 2021 -0700 Prepublish Checklist: Thumbnail Component (#7953) * thumbnail basics * new gear icon * fix import order * nits, fix eslint prop expectation commit 1302fbc Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Tue Jun 15 11:12:09 2021 -0600 Right Click Menu: Implementation Proposal (#7850) commit 4121f0f Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 15 15:14:32 2021 +0100 Packages: Move `units` to new structure (#7895) * Packages: Move `units` to new structure * Add readme.md * Stop redefining consts. * Remove dependency. * Remove dependency. * Use FULLBLEED_HEIGHT const. * Break into another file. * Fix comments. * Fix lint. * Fix lock file * Move isElementBelowLimit. commit fc6726f Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Mon Jun 14 10:53:46 2021 -0500 Accessibility: Keyboard Shortcuts Menu Accessibility and I18N Improvements (#7911) * working translatable strings * fix ctrl key width commit 87fd694 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 14 13:19:42 2021 +0300 Add date to fixture, too. (#7924) commit 618c78c Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Fri Jun 11 13:24:40 2021 -0700 Right Click Menus: UI prep (#7873) * storybook for right click menus to start looking at overlap and structure. Possible demo of dismissing menus all the time for everything. Adding ariaLabel to context menu, if present use that for aria-label of menu items, otherwise just use the visible label (there are a few new actions on these menus that could use a bit more description for non visual users * singular "style" usage for copy paste clear for all menus that have those options per copy update from Omar * one idea of how to handle menu positioning. * clean up * use kbd for shortcuts in context menu * fix 7897 while im in the context menu component * avoid nesting aria labels. use sprintf instead to consolidate a11y text. * small cleanup commit 7d1f176 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Fri Jun 11 12:03:05 2021 -0600 Quick Action Menu: Change background color opens the page background panel if it is collapsed (#7868) commit 2719019 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Fri Jun 11 17:04:53 2021 +0100 Unpin composer version in CI. (#7929) commit 00892bf Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Fri Jun 11 13:46:41 2021 +0100 Packages: Move `patterns` to new structure (#7910) * Move files to pattern package. * Handle prop types * Mocking. * Fix mocking. * More fixing. * Skip test for now * Better mocks * Only mock the necessary function. * Use requireActual. * Feedback. Co-authored-by: Miina Sikk <miina.sikk@gmail.com> commit bb73178 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:02:52 2021 +0200 Bump eslint from 7.27.0 to 7.28.0 (#7859) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pascal Birchler <pascalb@google.com> commit 8914eaa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:02:44 2021 +0200 Bump @wordpress/jest-puppeteer-axe from 3.0.4 to 3.0.5 (#7905) Bumps [@wordpress/jest-puppeteer-axe](https://github.com/WordPress/gutenberg/tree/HEAD/packages/jest-puppeteer-axe) from 3.0.4 to 3.0.5. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/jest-puppeteer-axe/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/jest-puppeteer-axe@3.0.5/packages/jest-puppeteer-axe) --- updated-dependencies: - dependency-name: "@wordpress/jest-puppeteer-axe" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 81fe907 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:02:22 2021 +0200 Bump core-js from 3.13.0 to 3.14.0 (#7904) Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.13.0 to 3.14.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.14.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6022448 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:01:44 2021 +0200 Bump @ampproject/toolbox-optimizer from 2.7.6 to 2.8.0 (#7902) Bumps [@ampproject/toolbox-optimizer](https://github.com/ampproject/amp-toolbox/tree/HEAD/packages/optimizer) from 2.7.6 to 2.8.0. - [Release notes](https://github.com/ampproject/amp-toolbox/releases) - [Changelog](https://github.com/ampproject/amp-toolbox/blob/main/CHANGELOG.md) - [Commits](https://github.com/ampproject/amp-toolbox/commits/v2.8.0/packages/optimizer) --- updated-dependencies: - dependency-name: "@ampproject/toolbox-optimizer" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 07d7057 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:01:34 2021 +0200 Bump @wordpress/eslint-plugin from 9.0.2 to 9.0.6 (#7901) Bumps [@wordpress/eslint-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin) from 9.0.2 to 9.0.6. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/eslint-plugin@9.0.6/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@wordpress/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 263f5ca Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 21:01:27 2021 +0200 Bump @babel/preset-env from 7.14.2 to 7.14.4 (#7900) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.2 to 7.14.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.4/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0455e2a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 20:59:47 2021 +0200 Bump jest from 27.0.3 to 27.0.4 (#7899) Bumps [jest](https://github.com/facebook/jest) from 27.0.3 to 27.0.4. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v27.0.3...v27.0.4) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 5c01b1c Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 18:57:42 2021 +0200 Output: Preload the first page’s background media (#7505) commit 2375895 Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 12:24:14 2021 +0200 Fix some JSDoc warnings commit 2ba0527 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Wed Jun 9 11:18:06 2021 +0100 Completely remove enabled experiment code (#7888) commit 6ebb7e1 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:17:05 2021 +0200 Bump @wordpress/block-editor from 6.1.0 to 6.1.3 (#7880) Bumps [@wordpress/block-editor](https://github.com/WordPress/gutenberg/tree/HEAD/packages/block-editor) from 6.1.0 to 6.1.3. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/block-editor@6.1.3/packages/block-editor) --- updated-dependencies: - dependency-name: "@wordpress/block-editor" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c82d47f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:16:58 2021 +0200 Bump rollup from 2.51.0 to 2.51.1 (#7883) Bumps [rollup](https://github.com/rollup/rollup) from 2.51.0 to 2.51.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.51.0...v2.51.1) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 75ac447 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:03:24 2021 +0200 Bump @wordpress/jest-console from 4.0.4 to 4.0.5 (#7886) Bumps [@wordpress/jest-console](https://github.com/WordPress/gutenberg/tree/HEAD/packages/jest-console) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/jest-console@4.0.5/packages/jest-console) --- updated-dependencies: - dependency-name: "@wordpress/jest-console" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f3b04f8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:02:34 2021 +0200 Bump jest-axe from 4.1.0 to 5.0.1 (#7882) Bumps [jest-axe](https://github.com/nickcolley/jest-axe) from 4.1.0 to 5.0.1. - [Release notes](https://github.com/nickcolley/jest-axe/releases) - [Changelog](https://github.com/nickcolley/jest-axe/blob/main/CHANGELOG.md) - [Commits](https://github.com/nickcolley/jest-axe/commits) --- updated-dependencies: - dependency-name: jest-axe dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit bbd6897 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:02:18 2021 +0200 Bump @wordpress/dom-ready from 3.1.0 to 3.1.1 (#7881) Bumps [@wordpress/dom-ready](https://github.com/WordPress/gutenberg/tree/HEAD/packages/dom-ready) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/dom-ready/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/dom-ready@3.1.1/packages/dom-ready) --- updated-dependencies: - dependency-name: "@wordpress/dom-ready" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c43362e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 11:02:12 2021 +0200 Bump axe-core from 4.2.1 to 4.2.2 (#7879) Bumps [axe-core](https://github.com/dequelabs/axe-core) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md) - [Commits](dequelabs/axe-core@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: axe-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit aaa3f7b Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:40:00 2021 +0200 Only run add-milestone action for main branch commit cdbf01c Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:37:57 2021 +0200 AMP: De-duplicate inline styles (#7743) Co-authored-by: Weston Ruter <westonruter@google.com> commit 5ead926 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:24:51 2021 +0200 Bump eslint-plugin-jsdoc from 35.0.0 to 35.1.3 (#7855) Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 35.0.0 to 35.1.3. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v35.0.0...v35.1.3) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 603fbdd Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:17:29 2021 +0200 Templates: add test for videos with `isOptimized` Template assets loaded from the CDN are always optimized commit 3c19e3c Author: Pascal Birchler <pascalb@google.com> Date: Wed Jun 9 10:12:33 2021 +0200 Fix typo in test commit 180564d Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:56 2021 +0200 Bump @testing-library/jest-dom from 5.12.0 to 5.13.0 (#7861) Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.12.0 to 5.13.0. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v5.12.0...v5.13.0) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 020e177 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:49 2021 +0200 Bump @wordpress/viewport from 3.1.0 to 3.1.1 (#7860) Bumps [@wordpress/viewport](https://github.com/WordPress/gutenberg/tree/HEAD/packages/viewport) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/viewport/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/viewport@3.1.1/packages/viewport) --- updated-dependencies: - dependency-name: "@wordpress/viewport" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 564a364 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:41 2021 +0200 Bump @wordpress/blocks from 9.1.1 to 9.1.2 (#7858) Bumps [@wordpress/blocks](https://github.com/WordPress/gutenberg/tree/HEAD/packages/blocks) from 9.1.1 to 9.1.2. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/blocks@9.1.2/packages/blocks) --- updated-dependencies: - dependency-name: "@wordpress/blocks" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6fa0ff7 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:35 2021 +0200 Bump polished from 4.1.2 to 4.1.3 (#7857) Bumps [polished](https://github.com/styled-components/polished) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/styled-components/polished/releases) - [Commits](styled-components/polished@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: polished dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 54ec5b2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:26 2021 +0200 Bump @wordpress/dependency-extraction-webpack-plugin from 3.1.2 to 3.1.4 (#7856) Bumps [@wordpress/dependency-extraction-webpack-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/dependency-extraction-webpack-plugin) from 3.1.2 to 3.1.4. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/changelog.txt) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/dependency-extraction-webpack-plugin@3.1.4/packages/dependency-extraction-webpack-plugin) --- updated-dependencies: - dependency-name: "@wordpress/dependency-extraction-webpack-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a608974 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:04:00 2021 +0200 Bump cssnano from 5.0.4 to 5.0.5 (#7853) Bumps [cssnano](https://github.com/cssnano/cssnano) from 5.0.4 to 5.0.5. - [Release notes](https://github.com/cssnano/cssnano/releases) - [Commits](https://github.com/cssnano/cssnano/compare/cssnano@5.0.4...cssnano@5.0.5) --- updated-dependencies: - dependency-name: cssnano dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 53565e5 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Jun 9 10:03:53 2021 +0200 Bump prettier from 2.3.0 to 2.3.1 (#7854) Bumps [prettier](https://github.com/prettier/prettier) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.3.0...2.3.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 83084dc Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Tue Jun 8 17:13:20 2021 -0600 Quick action menu: Remove feature flag (#7795) commit 5e5789d Author: Pascal Birchler <pascalb@google.com> Date: Tue Jun 8 18:53:16 2021 +0200 Fix equal sign alignment in unit test commit f7dcc8b Author: Pascal Birchler <pascalb@google.com> Date: Tue Jun 8 18:44:29 2021 +0200 Workflow: Add GitHub action for tagging PRs with releases (#7796) commit ecd2c12 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 16:54:58 2021 +0100 E2E Tests: fix user creation and switching (#7803) Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> Co-authored-by: Pascal Birchler <pascalb@google.com> commit c4837c6 Author: Pascal Birchler <pascalb@google.com> Date: Tue Jun 8 15:20:06 2021 +0200 Composer: remove `—no-suggest` option (#7864) This option is deprecated in Composer v2 commit 10b40b7 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 13:29:35 2021 +0100 Force composer 2.1.1 (#7863) commit df6695b Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 12:21:34 2021 +0100 Media: Mark 3P Media resources as optimized (#7847) commit 0971a88 Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 11:53:52 2021 +0300 Fix date resetting. (#7852) commit 18c9e36 Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 10:36:56 2021 +0300 Fix entering edit mode via click for Safari (#7782) * Remove using deprecated method that works incorrectly. * Add an alternative approach to keep caretRangeFromPoint in. * Add Safari fix * Remove redundant true. commit b16c9f5 Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Tue Jun 8 07:56:18 2021 +0100 Media: Transcode videos inserted from WordPress media modal (#7766) commit 974ff65 Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 09:30:31 2021 +0300 Fix colour picker focus styles. (#7801) commit 2c70b6a Author: Miina <miina.sikk@gmail.com> Date: Tue Jun 8 09:29:35 2021 +0300 Allow publishing stories "Immediately" (#7759) * Add the floating date logic. * Add reset date button. * Add unit test. * Replace some colours. * revert some color changes. * Nit * Keep poster when combining elements. * Revert commit. * Fix empty input issue. commit b801d43 Author: Samuel Estrella <samuelestrella226@gmail.com> Date: Mon Jun 7 12:57:32 2021 -0600 Right Click Menu: add feature flag (#7848) commit f554015 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 20:56:34 2021 +0200 Enable AMP ESM transformation once again (#7845) Reverts #7521 and #7749 commit a3a6538 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 21:50:12 2021 +0300 Avoid excess classes in preview mode (#7815) commit c0a0444 Author: Emily Bartman <emily.bartman@formidable.com> Date: Mon Jun 7 11:28:19 2021 -0700 Fix Karma Clear Animation & Undo Tests (#7820) * consolidate clear buttons into one * add style resets for opacity, border, radius. mostly copy from 7771 * WIP - seems the issues from 771 have followed us here and karma is only failing remote even when run headless! pushing up to run in CI to confirm suspicions. * WIP - adding additional check for clear button and a sleep to see if this passes remotely. Fixing a prop type that clutters the console when running tests * add a check for default border radius specific to text element since that is different from everything else. * rebase catch up * fix: karma tests for clearing animations and filters on elements quick actions Co-authored-by: Brittany Feenstra <brittany.feenstra@formidable.com> commit 6c8b2ad Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 19:35:18 2021 +0200 Fix incorrect publish time handling (#7800) commit 5132c07 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 19:34:53 2021 +0200 Links: remove empty data attributes (#7806) commit 1222255 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 15:51:54 2021 +0200 Bump puppeteer from 9.1.1 to 10.0.0 (#7835) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pascal Birchler <pascalb@google.com> commit 1789834 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 14:26:33 2021 +0200 Update PHPUnit workflow (#7816) commit 1c3ab77 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jun 7 14:26:06 2021 +0200 Migrate templates and text sets (#7841) Co-authored-by: swissspidy <swissspidy@users.noreply.github.com> commit b4a7c67 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 13:15:20 2021 +0200 Use custom video poster instead of default when available. (#7827) Co-authored-by: Pascal Birchler <pascalb@google.com> commit f8ca0ff Author: Jonny Harris <spacedmonkey@users.noreply.github.com> Date: Mon Jun 7 11:06:09 2021 +0100 Analytics: Update message when Site Kit is installed (#7701) Co-authored-by: Pascal Birchler <pascalb@google.com> commit c173c62 Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Mon Jun 7 04:42:37 2021 -0500 Animation: Fixed Delta for Background Zoom Animations (#7817) commit 4b896f6 Author: Pascal Birchler <pascalb@google.com> Date: Mon Jun 7 11:36:57 2021 +0200 Animations: honor `prefers-reduced-motion` setting (#7601) commit bdacadd Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Mon Jun 7 04:35:24 2021 -0500 Bug: Fix Help Center Links (#7829) commit 51d9210 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:30:19 2021 +0200 Bump @testing-library/dom from 7.31.0 to 7.31.2 (#7834) Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.31.0 to 7.31.2. - [Release notes](https://github.com/testing-library/dom-testing-library/releases) - [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/dom-testing-library@v7.31.0...v7.31.2) --- updated-dependencies: - dependency-name: "@testing-library/dom" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9061bc1 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:30:09 2021 +0200 Bump @wordpress/blocks from 9.1.0 to 9.1.1 (#7833) Bumps [@wordpress/blocks](https://github.com/WordPress/gutenberg/tree/HEAD/packages/blocks) from 9.1.0 to 9.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/blocks/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/blocks@9.1.1/packages/blocks) --- updated-dependencies: - dependency-name: "@wordpress/blocks" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c06d9c0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:29:48 2021 +0200 Bump @wordpress/e2e-test-utils from 5.2.0 to 5.3.0 (#7832) Bumps [@wordpress/e2e-test-utils](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils) from 5.2.0 to 5.3.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-test-utils/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/e2e-test-utils@5.3.0/packages/e2e-test-utils) --- updated-dependencies: - dependency-name: "@wordpress/e2e-test-utils" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2642a98 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:27:29 2021 +0200 Bump react-modal from 3.13.1 to 3.14.2 (#7837) Bumps [react-modal](https://github.com/reactjs/react-modal) from 3.13.1 to 3.14.2. - [Release notes](https://github.com/reactjs/react-modal/releases) - [Changelog](https://github.com/reactjs/react-modal/blob/master/CHANGELOG.md) - [Commits](reactjs/react-modal@v3.13.1...v3.14.2) --- updated-dependencies: - dependency-name: react-modal dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 97567a8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:27:21 2021 +0200 Bump @wordpress/url from 3.1.0 to 3.1.1 (#7830) Bumps [@wordpress/url](https://github.com/WordPress/gutenberg/tree/HEAD/packages/url) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/url/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/url@3.1.1/packages/url) --- updated-dependencies: - dependency-name: "@wordpress/url" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4cdc66e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:27:13 2021 +0200 Bump rollup from 2.50.3 to 2.51.0 (#7836) Bumps [rollup](https://github.com/rollup/rollup) from 2.50.3 to 2.51.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.50.3...v2.51.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2dcdf57 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 7 11:26:42 2021 +0200 Bump karma from 6.3.2 to 6.3.3 (#7831) Bumps [karma](https://github.com/karma-runner/karma) from 6.3.2 to 6.3.3. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v6.3.2...v6.3.3) --- updated-dependencies: - dependency-name: karma dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit fbc6397 Author: Miina <miina.sikk@gmail.com> Date: Mon Jun 7 08:13:53 2021 +0200 Always use full size for moveable. (#7814) commit 2fa2cad Author: Max Yinger <35983235+littlemilkstudio@users.noreply.github.com> Date: Sun Jun 6 18:01:16 2021 -0500 new defaults for rotate in animation (#7720) commit fc38c6e Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Thu Jun 3 14:18:02 2021 -0700 add disable reasons to places where jsx linting is ignored. remove old flakey test that is skipped. (#7808) commit c9214ca Author: Brittany Feenstra <brittany.feenstra@formidable.com> Date: Thu Jun 3 14:16:57 2021 -0700 Quick Action Menus: Reset element (#7809) * consolidate clear buttons into one * add style resets for opacity, border, radius. mostly copy from 7771 * WIP - seems the issues from 771 have followed us here and karma is only failing remote even when run headless! pushing up to run in CI to confirm suspicions. * WIP - adding additional check for clear button and a sleep to see if this passes remotely. Fixing a prop type that clutters the console when running tests * add a check for default border radius specific to text element since that is different from everything else. * rebase catch up commit 4be0072 Author: Emily Bartman <emily.bartman@formidable.com> Date: Thu Jun 3 12:42:39 2021 -0700 Quick Action Menu: Video Element (#7811) * quick actions: video selected * skip flaky tests * ...but actually skip them * skip didn't work delete for now--will address in a future PR commit 9a4906d Author: Pascal Birchler <pascalb@google.com> Date: Thu Jun 3 00:42:29 2021 +0200 Fix typo in lint workflow * Fix FULLBLEED_RATIO import * Fork is updated, srcSet fix is not needed * Exit eyedropper on focus out * Code clean up * Reset zoom before eyedropper init * Close eyedropper on ESC * Fix Safari glitches * Add comment * First easy optimisation: use only woff2 fonts * Use nicer icon * Move eyedropper to own file * Add safezone comment * Move consts to top * Add info: hide magnifier * Rename variables * useGlobalKeyDownEffect makes more sense here * Hide the magnifier when mouse is outside of the canvas * Remove redundant code * Comments clean up * Pre-generate the canvas image when possible * Chrome canvas border fix + RTL fix * Use existing color * Fix import order * Add karma test * Add shapshot * Fix lints. * Move comment. * Add behind a feature flag. Co-authored-by: Miina Sikk <miina.sikk@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
All for existing video that can be transcode to be shown in the default WordPress media picker. Once the video is select, insert a placeholder into content. From there, generate poster image and start the transcoding process.
Some video types, like mpg, the video will not have height and width data, so a default height and width will need to be set.
The allow list of transcodable mime type will have to moved to PHP, as it is needed for the jetpack integration. A filter is not required for this list of transcodable mime types.
This PR will likely be effected by #7699 #7691 #7317. I would like to see all these PRs merged first, so this PR can be rebased and retested.
Relevant Technical Choices
To-do
User-facing changes
Upload MOV ( that generates height and width )
Screen.Recording.2021-05-28.at.12.35.31.mov
Upload mpg ( that generates doesn't height and width )
Screen.Recording.2021-05-28.at.02.03.04.mov
Testing Instructions
QA
This PR can be tested by following these steps:
This functionality should be work, if users disables transcoding options. See dashboard -> settings.
UAT
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #7480