Fix issues related to selecting all text #11099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merapi
added
Type: Bug
|
Can you provide a bit more context in the PR description please. |
|
Size Change: -572 B (0%) Total Size: 2.59 MB
ℹ️ View Unchanged
|
merapi
changed the title
merapi
changed the title
|
Plugin builds for 2d3416a are ready 🛎️!
|
I've updated the default title and added some details about the solution, more details about the issue itself can be found in the linked tickets. |
|
Can we add Karma tests for this change? |
It's tricky, I believe you saw that: puppeteer/puppeteer#1313 // Testing this on the BROKEN version
await fixture.events.mouse.clickOn(frame, 30, 5); // enter the edit mode by clicking
await fixture.events.keyboard.shortcut('mod+a'); // doesn't work on macOS, maybe will work on Ubuntu
document.execCommand("selectAll"); // selects all, but it's not the same as MOD+A, so we can't use it
await fixture.events.keyboard.type('BAR');
// result: BAR, expected: Lorem...BAR...ipsum |
That could work, yeah. Better than no tests at all. |
|
@swissspidy We now have a test for it, PTAL at those |
swissspidy
reviewed
Mar 31, 2022
|
I think it's OK like that 👍 |
swissspidy
approved these changes
Mar 31, 2022
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are issues with selecting all text that were reported in #11034 and #11061.
There might be a different/better solution (because CMD+A generally works, it's more a problem with selection/focus), but this one is easy and harmless and most importantly - fixes all the issues with selecting all text.
I tell CMD+A to explicitly select all text in the text element.
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #11034
Fixes #11061