Media: Skip video optimization based on criteria #11454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Enhancement
spacedmonkey
reviewed
May 9, 2022
swissspidy
commented
May 9, 2022
swissspidy
commented
May 25, 2022
swissspidy
commented
May 25, 2022
swissspidy
changed the title
|
Size Change: +905 B (0%) Total Size: 2.65 MB
ℹ️ View Unchanged
|
|
Plugin builds for 627a736 are ready 🛎️!
|
packages/story-editor/src/app/media/utils/useMediaUploadQueue/index.js
Outdated
Show resolved
Hide resolved
swissspidy
commented
Jul 12, 2022
packages/story-editor/src/components/library/panes/media/common/innerElement.js
Show resolved
Hide resolved
swissspidy
commented
Jul 13, 2022
packages/story-editor/src/app/media/utils/useMediaUploadQueue/constants.js
Show resolved
Hide resolved
|
I am not longer seeing progress bars on uploading items :( See #11454 (comment) |
|
I am seeing the poster generation hanging. Screen.Recording.2022-07-14.at.11.57.17.movI believe this is happening because poster generation is trying to happen on blob url. Not sure why this is happening. |
This seems to be happening on main as well. |
spacedmonkey
approved these changes
Jul 14, 2022
|
@spacedmonkey @swissspidy I still see the "Video optimization" message when I upload a video that is a mp4 file, 3.97MB, 720x1280. The video that I am uploading is the second one. The first is to show that the message is still being displayed. |
|
@felipebochehin87 Good catch! There was some incorrect comparison being used ("<" instead of "<="). However, your video also has a frame rate of only 20 FPS, whereas the recommendation is 24+ FPS, which is why your video is still being optimized. So that is still expected. Apologies for not updating the instructions accordingly. |
|
Oh thanks @swissspidy! I'll retest right now :) |
|
@swissspidy I uploaded the video below and also got the message: This video is 1280x720, 120 FPS, 2.12MB. Am I missing anything else? |
|
@felipebochehin87 Please try again now :-) My fix wasn't uploaded to the QA environment yet when I wrote my comment. But now it's updated there and the video is uploading without optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to avoid needlessly running video optimization on videos that are already in very good shape, for example when the creator has manually optimized videos before upload.
The aim is to improve overall user experience and performance during uploads.
Summary
Relevant Technical Choices
Uses mediainfo.js to get detailed information about codecs, file size, frame rate, etc.
For the start, small videos (< 5MB), with either MP4 or WEBM type and max dimensions of 720x1280, will be automatically marked as optimized.
To-do
User-facing changes
No visual changes per se, but when uploading smaller videos fitting the criteria they will not be optimized by default anymore.
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11405