Shopping: Support drag & drop from library #11913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timarney
changed the title
timarney
added
Group: Library
Pod: WP
Group: Shopping
timarney
force-pushed
the
fix/11708-drag-drop-shopping-image
branch
from
8712a47
to
da30509
Compare
swissspidy
requested changes
Jul 15, 2022
packages/story-editor/src/components/library/panes/shopping/productList.js
Outdated
Show resolved
Hide resolved
packages/story-editor/src/components/library/panes/shopping/productImage.js
Show resolved
Hide resolved
packages/story-editor/src/components/library/panes/shared/libraryMoveable.js
Outdated
Show resolved
Hide resolved
|
Size Change: +149 B (0%) Total Size: 2.66 MB
ℹ️ View Unchanged
|
|
Plugin builds for 60206b8 are ready 🛎️!
|
miina
reviewed
Jul 18, 2022
packages/story-editor/src/components/library/panes/shared/libraryMoveable.js
Outdated
Show resolved
Hide resolved
packages/story-editor/src/components/library/panes/shopping/productImage.js
Show resolved
Hide resolved
|
|
|
Same here |
|
Added a conditional to fix the |
spacedmonkey
approved these changes
Jul 21, 2022
swissspidy
reviewed
Jul 21, 2022
packages/story-editor/src/components/library/panes/shopping/productImage.js
Outdated
Show resolved
Hide resolved
swissspidy
requested changes
Jul 21, 2022
|
Should the tooltip appear on when hover over the image when you try and drag it when you are not allowed? |
|
We can keep the tooltip as-is, only on the button. |
spacedmonkey
approved these changes
Jul 21, 2022
swissspidy
approved these changes
Jul 21, 2022
packages/story-editor/src/components/library/panes/shopping/product.js
Outdated
Show resolved
Hide resolved
miina
approved these changes
Jul 22, 2022
|
Would be nice to add a Karma test as well for it if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add support for dragging products from the library to the canvas.
Summary
Adds draggable product image
Relevant Technical Choices
To-do
Handle dragging product that already exists on the canvas
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11708