Add grouping to templates #11924

mwritter · 2022-07-15T20:06:43Z

Context

Add grouping, group names, and layer locking to templates

Summary

Adds grouping, group names, and layer locking to templates

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Go to Explore Templates
Click though the templates

Notice most templates (that seem to need it, based on amount of layers - about 10 layers or more) now utilize layer grouping and locking.

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

This PR addresses an existing issue and I have linked this PR to it in ZenHub
I have tested this code to the best of my abilities
I have verified accessibility to the best of my abilities (docs)
I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
I have added documentation where necessary
I have added a matching Type: XYZ label to the PR

Fixes #11697

github-actions · 2022-07-15T20:12:45Z

Size Change: +27.8 kB (+1%)

Total Size: 2.68 MB

Filename	Size	Change
`assets/js/chunk-web-stories-template-0.js`	11.8 kB	+1.24 kB (+12%)	⚠️
`assets/js/chunk-web-stories-template-1.js`	9.55 kB	+543 B (+6%)	🔍
`assets/js/chunk-web-stories-template-10.js`	7.34 kB	+438 B (+6%)	🔍
`assets/js/chunk-web-stories-template-11.js`	8.79 kB	+283 B (+3%)
`assets/js/chunk-web-stories-template-12.js`	9.66 kB	+183 B (+2%)
`assets/js/chunk-web-stories-template-13.js`	7.41 kB	+112 B (+2%)
`assets/js/chunk-web-stories-template-14.js`	7.86 kB	+279 B (+4%)
`assets/js/chunk-web-stories-template-15.js`	8.53 kB	+323 B (+4%)
`assets/js/chunk-web-stories-template-16.js`	10.8 kB	+520 B (+5%)	🔍
`assets/js/chunk-web-stories-template-17.js`	8.83 kB	+309 B (+4%)
`assets/js/chunk-web-stories-template-18.js`	9.84 kB	+797 B (+9%)	🔍
`assets/js/chunk-web-stories-template-19.js`	10.6 kB	+569 B (+6%)	🔍
`assets/js/chunk-web-stories-template-2.js`	9.43 kB	+268 B (+3%)
`assets/js/chunk-web-stories-template-20.js`	9.01 kB	+418 B (+5%)	🔍
`assets/js/chunk-web-stories-template-21.js`	9.74 kB	+578 B (+6%)	🔍
`assets/js/chunk-web-stories-template-22.js`	7.96 kB	+589 B (+8%)	🔍
`assets/js/chunk-web-stories-template-23.js`	7.46 kB	+479 B (+7%)	🔍
`assets/js/chunk-web-stories-template-24.js`	12 kB	+1.18 kB (+11%)	⚠️
`assets/js/chunk-web-stories-template-26.js`	7.23 kB	+381 B (+6%)	🔍
`assets/js/chunk-web-stories-template-27.js`	7.67 kB	+315 B (+4%)
`assets/js/chunk-web-stories-template-28.js`	9.12 kB	+630 B (+7%)	🔍
`assets/js/chunk-web-stories-template-29.js`	9.24 kB	+749 B (+9%)	🔍
`assets/js/chunk-web-stories-template-3.js`	8.4 kB	+181 B (+2%)
`assets/js/chunk-web-stories-template-30.js`	7.97 kB	+293 B (+4%)
`assets/js/chunk-web-stories-template-31.js`	10.4 kB	+754 B (+8%)	🔍
`assets/js/chunk-web-stories-template-32.js`	13.3 kB	+1.15 kB (+9%)	🔍
`assets/js/chunk-web-stories-template-33.js`	9.32 kB	+452 B (+5%)	🔍
`assets/js/chunk-web-stories-template-35.js`	9.12 kB	+310 B (+4%)
`assets/js/chunk-web-stories-template-36.js`	12.7 kB	+1.15 kB (+10%)	⚠️
`assets/js/chunk-web-stories-template-39.js`	8.34 kB	+671 B (+9%)	🔍
`assets/js/chunk-web-stories-template-4.js`	12.7 kB	+1.22 kB (+11%)	⚠️
`assets/js/chunk-web-stories-template-40.js`	10.2 kB	+1.06 kB (+12%)	⚠️
`assets/js/chunk-web-stories-template-43.js`	8.74 kB	+370 B (+4%)
`assets/js/chunk-web-stories-template-44.js`	11.1 kB	+961 B (+9%)	🔍
`assets/js/chunk-web-stories-template-45.js`	7.69 kB	+568 B (+8%)	🔍
`assets/js/chunk-web-stories-template-46.js`	5.24 kB	+228 B (+5%)	🔍
`assets/js/chunk-web-stories-template-47.js`	9.4 kB	+945 B (+11%)	⚠️
`assets/js/chunk-web-stories-template-48.js`	8.83 kB	+512 B (+6%)	🔍
`assets/js/chunk-web-stories-template-5.js`	9.94 kB	+564 B (+6%)	🔍
`assets/js/chunk-web-stories-template-50.js`	9.13 kB	+869 B (+11%)	⚠️
`assets/js/chunk-web-stories-template-51.js`	10.4 kB	+556 B (+6%)	🔍
`assets/js/chunk-web-stories-template-52.js`	10.3 kB	+274 B (+3%)
`assets/js/chunk-web-stories-template-54.js`	7.63 kB	+116 B (+2%)
`assets/js/chunk-web-stories-template-55.js`	7.1 kB	+542 B (+8%)	🔍
`assets/js/chunk-web-stories-template-56.js`	9.89 kB	+394 B (+4%)
`assets/js/chunk-web-stories-template-57.js`	14.8 kB	+797 B (+6%)	🔍
`assets/js/chunk-web-stories-template-58.js`	5.72 kB	+111 B (+2%)
`assets/js/chunk-web-stories-template-59.js`	8.91 kB	+398 B (+5%)	🔍
`assets/js/chunk-web-stories-template-60.js`	9.36 kB	+467 B (+5%)	🔍
`assets/js/chunk-web-stories-template-7.js`	7.44 kB	+233 B (+3%)
`assets/js/chunk-web-stories-template-8.js`	8.9 kB	+503 B (+6%)	🔍

ℹ️ View Unchanged

Filename	Size	Change
`assets/css/carousel-view-rtl.css`	702 B	0 B
`assets/css/carousel-view.css`	701 B	0 B
`assets/css/web-stories-block-rtl.css`	4.52 kB	0 B
`assets/css/web-stories-block.css`	4.56 kB	0 B
`assets/css/web-stories-embed-rtl.css`	318 B	0 B
`assets/css/web-stories-embed.css`	317 B	0 B
`assets/css/web-stories-list-styles-rtl.css`	2.36 kB	0 B
`assets/css/web-stories-list-styles.css`	2.39 kB	0 B
`assets/css/web-stories-theme-style-twentyeleven-rtl.css`	102 B	0 B
`assets/css/web-stories-theme-style-twentyeleven.css`	102 B	0 B
`assets/css/web-stories-theme-style-twentyfifteen-rtl.css`	251 B	0 B
`assets/css/web-stories-theme-style-twentyfifteen.css`	251 B	0 B
`assets/css/web-stories-theme-style-twentyfourteen-rtl.css`	287 B	0 B
`assets/css/web-stories-theme-style-twentyfourteen.css`	287 B	0 B
`assets/css/web-stories-theme-style-twentyseventeen-rtl.css`	288 B	0 B
`assets/css/web-stories-theme-style-twentyseventeen.css`	288 B	0 B
`assets/css/web-stories-theme-style-twentysixteen-rtl.css`	224 B	0 B
`assets/css/web-stories-theme-style-twentysixteen.css`	224 B	0 B
`assets/css/web-stories-theme-style-twentyten-rtl.css`	143 B	0 B
`assets/css/web-stories-theme-style-twentyten.css`	143 B	0 B
`assets/css/web-stories-theme-style-twentytwelve-rtl.css`	256 B	0 B
`assets/css/web-stories-theme-style-twentytwelve.css`	256 B	0 B
`assets/css/web-stories-theme-style-twentytwenty-rtl.css`	86 B	0 B
`assets/css/web-stories-theme-style-twentytwenty.css`	86 B	0 B
`assets/css/web-stories-theme-style-twentytwentyone-rtl.css`	326 B	0 B
`assets/css/web-stories-theme-style-twentytwentyone.css`	326 B	0 B
`assets/css/web-stories-widget-rtl.css`	482 B	0 B
`assets/css/web-stories-widget.css`	482 B	0 B
`assets/css/wp-dashboard-rtl.css`	657 B	0 B
`assets/css/wp-dashboard.css`	659 B	0 B
`assets/css/wp-story-editor-rtl.css`	737 B	0 B
`assets/css/wp-story-editor.css`	738 B	0 B
`assets/js/1590.js`	1.14 MB	0 B
`assets/js/1814.js`	7.46 kB	0 B
`assets/js/2505.js`	34.9 kB	0 B
`assets/js/3617.js`	224 kB	0 B
`assets/js/4422.js`	49.3 kB	0 B
`assets/js/5980.js`	5.48 kB	0 B
`assets/js/carousel-view.js`	3.41 kB	0 B
`assets/js/chunk-colorthief.js`	2.64 kB	0 B
`assets/js/chunk-ffmpeg.js`	5.64 kB	0 B
`assets/js/chunk-focus-visible.js`	1.01 kB	0 B
`assets/js/chunk-getStoryMarkup.js`	5.82 kB	0 B
`assets/js/chunk-html-to-image.js`	4.6 kB	0 B
`assets/js/chunk-opentype.js`	96 B	0 B
`assets/js/chunk-react-calendar.js`	12.4 kB	0 B
`assets/js/chunk-react-color.js`	44.3 kB	0 B
`assets/js/chunk-resize-observer-polyfill.js`	2.57 kB	0 B
`assets/js/chunk-web-animations-js.js`	14.6 kB	0 B
`assets/js/chunk-web-stories-template-0-metaData.js`	546 B	0 B
`assets/js/chunk-web-stories-template-1-metaData.js`	540 B	0 B
`assets/js/chunk-web-stories-template-10-metaData.js`	533 B	0 B
`assets/js/chunk-web-stories-template-11-metaData.js`	540 B	0 B
`assets/js/chunk-web-stories-template-12-metaData.js`	496 B	0 B
`assets/js/chunk-web-stories-template-13-metaData.js`	525 B	0 B
`assets/js/chunk-web-stories-template-14-metaData.js`	582 B	0 B
`assets/js/chunk-web-stories-template-15-metaData.js`	544 B	0 B
`assets/js/chunk-web-stories-template-16-metaData.js`	588 B	0 B
`assets/js/chunk-web-stories-template-17-metaData.js`	539 B	0 B
`assets/js/chunk-web-stories-template-18-metaData.js`	585 B	0 B
`assets/js/chunk-web-stories-template-19-metaData.js`	501 B	0 B
`assets/js/chunk-web-stories-template-2-metaData.js`	586 B	0 B
`assets/js/chunk-web-stories-template-20-metaData.js`	548 B	0 B
`assets/js/chunk-web-stories-template-21-metaData.js`	534 B	0 B
`assets/js/chunk-web-stories-template-22-metaData.js`	525 B	0 B
`assets/js/chunk-web-stories-template-23-metaData.js`	605 B	0 B
`assets/js/chunk-web-stories-template-24-metaData.js`	518 B	0 B
`assets/js/chunk-web-stories-template-25-metaData.js`	544 B	0 B
`assets/js/chunk-web-stories-template-25.js`	7.07 kB	0 B
`assets/js/chunk-web-stories-template-26-metaData.js`	601 B	0 B
`assets/js/chunk-web-stories-template-27-metaData.js`	543 B	0 B
`assets/js/chunk-web-stories-template-28-metaData.js`	532 B	0 B
`assets/js/chunk-web-stories-template-29-metaData.js`	561 B	0 B
`assets/js/chunk-web-stories-template-3-metaData.js`	540 B	0 B
`assets/js/chunk-web-stories-template-30-metaData.js`	576 B	0 B
`assets/js/chunk-web-stories-template-31-metaData.js`	503 B	0 B
`assets/js/chunk-web-stories-template-32-metaData.js`	551 B	0 B
`assets/js/chunk-web-stories-template-33-metaData.js`	492 B	0 B
`assets/js/chunk-web-stories-template-34-metaData.js`	571 B	0 B
`assets/js/chunk-web-stories-template-34.js`	7.57 kB	0 B
`assets/js/chunk-web-stories-template-35-metaData.js`	565 B	0 B
`assets/js/chunk-web-stories-template-36-metaData.js`	576 B	0 B
`assets/js/chunk-web-stories-template-37-metaData.js`	528 B	0 B
`assets/js/chunk-web-stories-template-37.js`	6.47 kB	0 B
`assets/js/chunk-web-stories-template-38-metaData.js`	572 B	0 B
`assets/js/chunk-web-stories-template-38.js`	7.96 kB	0 B
`assets/js/chunk-web-stories-template-39-metaData.js`	589 B	0 B
`assets/js/chunk-web-stories-template-4-metaData.js`	565 B	0 B
`assets/js/chunk-web-stories-template-40-metaData.js`	556 B	0 B
`assets/js/chunk-web-stories-template-41-metaData.js`	572 B	0 B
`assets/js/chunk-web-stories-template-41.js`	7.75 kB	0 B
`assets/js/chunk-web-stories-template-42-metaData.js`	522 B	0 B
`assets/js/chunk-web-stories-template-42.js`	7 kB	0 B
`assets/js/chunk-web-stories-template-43-metaData.js`	558 B	0 B
`assets/js/chunk-web-stories-template-44-metaData.js`	582 B	0 B
`assets/js/chunk-web-stories-template-45-metaData.js`	564 B	0 B
`assets/js/chunk-web-stories-template-46-metaData.js`	531 B	0 B
`assets/js/chunk-web-stories-template-47-metaData.js`	592 B	0 B
`assets/js/chunk-web-stories-template-48-metaData.js`	556 B	0 B
`assets/js/chunk-web-stories-template-49-metaData.js`	518 B	0 B
`assets/js/chunk-web-stories-template-49.js`	9.7 kB	0 B
`assets/js/chunk-web-stories-template-5-metaData.js`	555 B	0 B
`assets/js/chunk-web-stories-template-50-metaData.js`	504 B	0 B
`assets/js/chunk-web-stories-template-51-metaData.js`	527 B	0 B
`assets/js/chunk-web-stories-template-52-metaData.js`	602 B	0 B
`assets/js/chunk-web-stories-template-53-metaData.js`	553 B	0 B
`assets/js/chunk-web-stories-template-53.js`	5.79 kB	0 B
`assets/js/chunk-web-stories-template-54-metaData.js`	547 B	0 B
`assets/js/chunk-web-stories-template-55-metaData.js`	574 B	0 B
`assets/js/chunk-web-stories-template-56-metaData.js`	543 B	0 B
`assets/js/chunk-web-stories-template-57-metaData.js`	528 B	0 B
`assets/js/chunk-web-stories-template-58-metaData.js`	556 B	0 B
`assets/js/chunk-web-stories-template-59-metaData.js`	588 B	0 B
`assets/js/chunk-web-stories-template-6-metaData.js`	569 B	0 B
`assets/js/chunk-web-stories-template-6.js`	7.04 kB	0 B
`assets/js/chunk-web-stories-template-60-metaData.js`	509 B	0 B
`assets/js/chunk-web-stories-template-7-metaData.js`	569 B	0 B
`assets/js/chunk-web-stories-template-8-metaData.js`	569 B	0 B
`assets/js/chunk-web-stories-template-9-metaData.js`	581 B	0 B
`assets/js/chunk-web-stories-template-9.js`	8.49 kB	0 B
`assets/js/chunk-web-stories-templates.js`	443 B	0 B
`assets/js/chunk-web-stories-textset-0.js`	5.08 kB	0 B
`assets/js/chunk-web-stories-textset-1.js`	6.64 kB	0 B
`assets/js/chunk-web-stories-textset-2.js`	7.67 kB	0 B
`assets/js/chunk-web-stories-textset-3.js`	15.1 kB	0 B
`assets/js/chunk-web-stories-textset-4.js`	4.16 kB	0 B
`assets/js/chunk-web-stories-textset-5.js`	5.49 kB	0 B
`assets/js/chunk-web-stories-textset-6.js`	5.3 kB	0 B
`assets/js/chunk-web-stories-textset-7.js`	10.2 kB	0 B
`assets/js/generateBlurhash.worker.worker.js`	1.1 kB	0 B
`assets/js/imgareaselect.js`	3.77 kB	0 B
`assets/js/lightbox.js`	550 B	0 B
`assets/js/tinymce-button.js`	2.84 kB	0 B
`assets/js/web-stories-activation-notice.js`	26.9 kB	0 B
`assets/js/web-stories-block.js`	22.7 kB	0 B
`assets/js/web-stories-embed.js`	20 B	0 B
`assets/js/web-stories-widget.js`	587 B	0 B
`assets/js/wp-dashboard.js`	72.7 kB	-6 B (0%)
`assets/js/wp-story-editor.js`	325 kB	-21 B (0%)

_{compressed-size-action}

googleforcreators-bot · 2022-07-15T20:15:21Z

Plugin builds for b629149 are ready 🛎️!

Download development build
Download production build

…uping_To_Templates

packages/templates/src/raw/fresh-and-bright/template.json

…template.

miina · 2022-07-27T13:53:02Z

@merapi @barklund I've reviewed the changes of this PR and added some fixes and additions, this should be ready for review now.

merapi

After spending 10 minutes reviewing 27k lines of mostly auto-generated code I have enough 😜 LG 👍🏻

mwritter added 5 commits July 12, 2022 14:09

12-hours-in-barcelona

68490a8

Only change the bits we need to

4152b3d

all-about-cars

548deb5

More groupings

b0e4d3f

More groupings

12ce611

mwritter requested review from mflorida, sblinde and swissspidy July 15, 2022 20:07

mwritter self-assigned this Jul 15, 2022

mwritter added Type: Enhancement New feature or improvement of an existing feature Pod: Prometheus Package: Templates /packages/templates labels Jul 15, 2022

swissspidy requested a review from merapi July 18, 2022 09:36

barklund changed the title ~~Feature/11697 add grouping to templates~~ Add grouping to templates Jul 18, 2022

swissspidy removed the Pod: Pea label Jul 19, 2022

swissspidy assigned merapi and miina and unassigned mwritter and merapi Jul 20, 2022

Merge remote-tracking branch 'origin/main' into feature/11697_Add_Gro…

721a295

…uping_To_Templates

miina reviewed Jul 25, 2022

View reviewed changes

packages/templates/src/raw/fresh-and-bright/template.json Show resolved Hide resolved

miina added 6 commits July 26, 2022 11:29

Add missing group for share button

58a2f56

Collapse by default.

0aecea6

Improve groups for template.

4ae99b1

Move elements around to actually display in groups.

537bf83

Move elements around to actually display in groups for the Art Books …

0ad4dcc

…template.

Fix Hawaii template. Run prettier

addbdb3

miina added 6 commits July 26, 2022 16:09

Add groups to how contract tracing works template

4a7d15a

Fix for template: How to buy art on the internet

69054f7

12-hours-in-barcelona

b0c91d2

ways-to-eat-avocado

057ec6d

Experience Thai

6fd6209

Experience Thai

b629149

miina requested review from barklund and removed request for mflorida and sblinde July 27, 2022 13:52

merapi approved these changes Jul 27, 2022

View reviewed changes

felipebochehin87 mentioned this pull request Jul 28, 2022

Templates: Make use of layer naming/grouping/locking #11697

Closed

swissspidy merged commit 054e894 into main Jul 28, 2022

swissspidy deleted the feature/11697_Add_Grouping_To_Templates branch July 28, 2022 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add grouping to templates #11924

Add grouping to templates #11924

mwritter commented Jul 15, 2022 •

edited

github-actions bot commented Jul 15, 2022

googleforcreators-bot commented Jul 15, 2022 •

edited

miina commented Jul 27, 2022

merapi left a comment

Add grouping to templates #11924

Add grouping to templates #11924

Conversation

mwritter commented Jul 15, 2022 • edited

Context

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

github-actions bot commented Jul 15, 2022

googleforcreators-bot commented Jul 15, 2022 • edited

miina commented Jul 27, 2022

merapi left a comment

Choose a reason for hiding this comment

mwritter commented Jul 15, 2022 •

edited

googleforcreators-bot commented Jul 15, 2022 •

edited