Fix story poster meta fallback #11982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +34 B (0%) Total Size: 2.66 MB ℹ️ View Unchanged
|
|
See how this just filled up the post meta table:
|
|
Plugin builds for a86d597 are ready 🛎️!
|
merapi
approved these changes
Jul 21, 2022
|
This seems good to me. |
swissspidy
changed the title
spacedmonkey
approved these changes
Jul 22, 2022
|
Looks good in QA. |
swissspidy
added a commit
that referenced
this pull request
Jul 25, 2022
This was referenced Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It was reported that poster images could not be reliably saved anymore, with the
Summary
While looking into this bug, I noticed two issues:
web_stories_postermeta field set with the poster URL.saveStoryByIdcallback override the poster image with the meta value even if there was a legit featured image setCombined, this led to the reported behavior of the story poster randomly resetting to the previous one.
Relevant Technical Choices
To-do
This needs tests.
User-facing changes
No more random poster resets
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11980