Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use number of re-run attempts for Percy nonce #11986

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

swissspidy
Copy link
Collaborator

Context

#11983 (comment)

Summary

github.run_attempt is a unique number for each attempt of a particular workflow run in a repository, starting at 1 and incrementing with each re-run.

Using this number for workflow re-runs avoids Percy warning “the build is already finalized”, because otherwise the nonce stays the same between runs.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #

`github.run_attempt` is a unique number for each attempt of a particular workflow run in a repository, starting at 1 and incrementing with each re-run.

Using this number for workflow re-runs avoids Percy warning “the build is already finalized”, because otherwise the nonce stays the same between runs.
@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP labels Jul 22, 2022
@swissspidy swissspidy merged commit 01f59e9 into main Jul 22, 2022
@swissspidy swissspidy deleted the fix/percy-nonce-reruns branch July 22, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant