Media Recording: Add Pause/Resume Support #12000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Enhancement
swissspidy
force-pushed
the
add/11923-pause-recording
branch
from
e06d10b
to
b489ded
Compare
swissspidy
force-pushed
the
add/11923-pause-recording
branch
from
b489ded
to
43e2282
Compare
|
Plugin builds for 43e2282 are ready 🛎️!
|
miina
approved these changes
Jul 27, 2022
| @@ -53,7 +53,7 @@ const Wrapper = styled(Text).attrs({ | |||
| function DurationIndicator() { | |||
| const { duration, isRecording } = useMediaRecording(({ state }) => ({ | |||
| duration: state.duration, | |||
| isRecording: state.status === 'recording', | |||
| isRecording: ['recording', 'paused'].includes(state.status), | |||
There was a problem hiding this comment.
Nit: Would be nice to have the statuses in a constant since these are used in multiple places.
There was a problem hiding this comment.
Yeah true. Using TypeScript would be nice here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR adds a new Stop/Resume button to video recording.
Relevant Technical Choices
To-do
User-facing changes
Demo (ignore the blank stream, I didn't connect my virtual camera)
Screen.Recording.2022-07-25.at.15.44.24.mov
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11923