Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed delay before trimming a new recording #12001

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

barklund
Copy link
Contributor

@barklund barklund commented Jul 25, 2022

Context

This was surprisingly easy to fix by simply seeking to MAX_SAFE_INTEGER when trimming is entered with a video node with duration set to infinity (once seeking past the end, the DOM will be updated with the actual video duration).

Testing Instructions

  1. Start a video recording
  2. Record at least a minute of video
  3. As soon as the recording is stopped, press the scissor icon to go into trimming mode
  4. Observe that trimming mode is entered instantly with (almost) no delay
  5. Test this in a large combination of OS and browser

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #11987

@barklund barklund added Type: Bug Something isn't working Pod: Prometheus labels Jul 25, 2022
@barklund barklund self-assigned this Jul 25, 2022
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Jul 25, 2022

Plugin builds for 616905e are ready 🛎️!

@merapi
Copy link
Contributor

merapi commented Jul 25, 2022

First round of testing: LG ~instant 😃 we just need to test it on different browser/os configurations.

@swissspidy swissspidy merged commit 7fb81dc into main Jul 27, 2022
@swissspidy swissspidy deleted the fix/11987-record-trim-delay branch July 27, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trimming UI takes a long time to appear
4 participants