Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jest test for custom font selection #12017

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Add Jest test for custom font selection #12017

merged 4 commits into from
Jul 26, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Jul 25, 2022 •
edited

Context

This replaces an end to end test that was removed in #11782

Summary

Adds Jest test for font selection

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #11929

@timarney timarney added Pod: WP Type: Infrastructure Changes impacting testing infrastructure or build tooling labels Jul 25, 2022
@timarney timarney self-assigned this Jul 26, 2022
@timarney timarney marked this pull request as ready for review July 26, 2022 09:41
@swissspidy swissspidy merged commit 54f9a08 into main Jul 26, 2022
@swissspidy swissspidy deleted the fix/11929-custom-font-selction branch July 26, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@timarney timarney

Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Jest test for custom font selection
2 participants
@timarney @swissspidy