Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Remove showSemanticHeadings feature flag code #12027

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Jul 26, 2022

Context

This feature has been enabled by default in v1.23.0.

Feature PR #11888

Summary

Removes showSemanticHeadings feature flag

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. Navigate to a Story within the Editor.
  2. Add multiple text elements with variying font sizes.
  3. Note that the feature is on by default ... You should be able to see in the Style section of the sidebar, underneath a new Accessibility tab, the type of semantic heading.

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #11996

@timarney timarney self-assigned this Jul 26, 2022
@timarney timarney added Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: WP labels Jul 26, 2022
@timarney timarney marked this pull request as ready for review July 26, 2022 22:19
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Jul 27, 2022

Plugin builds for 386ba41 are ready 🛎️!

@swissspidy swissspidy merged commit 02f424e into main Jul 28, 2022
@swissspidy swissspidy deleted the fix/11996-show-semantic-headings-feature-flag branch July 28, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Remove showSemanticHeadings feature flag code
3 participants