Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates: improve text element usage #12061

Merged
merged 93 commits into from
Aug 8, 2022
Merged

Conversation

miina
Copy link
Contributor

@miina miina commented Aug 2, 2022

Context

Improves templates by using Fill / Highlight / Border features of the text element instead of using separate shape for the same effect.

Summary

Relevant Technical Choices

To-do

User-facing changes

Buttons etc. in templates that previously used a text element + background shape for the background / border now use Fill / border features instead. Note that this was not possible in 100% places, e.g. in some places it seemed like the text was purposefully not vertically centred, making it not possible to use the Fill background feature.

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. Check some templates (see the Files changed to see which templates have been changed) and see that where possible, button-like elements and other texts with background now consist of 1 text element with Fill background / border instead of text + shape.

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #12032

@miina miina added Type: Enhancement New feature or improvement of an existing feature Pod: Prometheus labels Aug 2, 2022
@miina miina self-assigned this Aug 2, 2022
@miina miina marked this pull request as ready for review August 3, 2022 13:36
@miina miina requested review from barklund and merapi August 3, 2022 13:36
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 3, 2022

Plugin builds for 8ede9e7 are ready 🛎️!

Base automatically changed from add/11928-template-heading-levels to main August 4, 2022 09:08
@miina miina merged commit ef62441 into main Aug 8, 2022
@miina miina deleted the fix/12032-templates-text-usage branch August 8, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Templates to improve / fix text element usage
5 participants