-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating Menu: Allow fixing / disabling the element menu #12095
Conversation
@barklund This is still waiting for the UX confirmation but the general logic should be in place, would be great if you could review already. |
Looks good, but UX-wise: without the video, I wouldn't notice the "Toggle element toolbar" button - let's talk about it on the design sync. |
Plugin builds for 749e6f1 are ready 🛎️!
|
PR feedback
This is now ready -- only waiting for UX to switch the Toolbar icon + update the copy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - I 🕺 this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
I centered the icon.
Context
Summary
Adds a new Settings menu to the Element toolbar/floating menu that allows moving the menu to the top / to the element / allows persistently closing the toolbar.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #11570