Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating Menu: Allow fixing / disabling the element menu #12095

Merged
merged 19 commits into from
Aug 29, 2022

Conversation

miina
Copy link
Contributor

@miina miina commented Aug 11, 2022

Context

Summary

Adds a new Settings menu to the Element toolbar/floating menu that allows moving the menu to the top / to the element / allows persistently closing the toolbar.

Relevant Technical Choices

  • Increases the header height a bit to fit the toolbar

To-do

  • Confirm UX
  • Add icon from UX / update copy
  • Tests

User-facing changes

Screenshot 2022-08-17 at 17 38 58

Screenshot 2022-08-17 at 17 38 51

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. Add an element
  2. See the new Settings menu in the floating menu.
  3. Verify that it's possible to place the element above the page using the "Fix to top" option and back to the element with the "Fix to element" option.
  4. Verify that closing the menu from "Always hide" will persistently hide the menu (deselecting and selecting the element again will not reopen the menu)
  5. Verify that when closing the menu from "Always hide", a new button appears to the bottom right area and that button is highlighted after closing the menu.
  6. Verify that the button opens the menu again

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

trackEvent('floating_menu', {
      name: 'reposition_menu',
      position,
    });

trackEvent('floating_menu', {
      name: 'persistent_menu_hide',
    });

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #11570

@miina miina added Type: Enhancement New feature or improvement of an existing feature Pod: Prometheus labels Aug 11, 2022
@miina miina self-assigned this Aug 11, 2022
@miina miina requested a review from barklund August 12, 2022 08:36
@miina
Copy link
Contributor Author

miina commented Aug 12, 2022

@barklund This is still waiting for the UX confirmation but the general logic should be in place, would be great if you could review already.

@miina miina requested a review from merapi August 15, 2022 14:03
@merapi
Copy link
Contributor

merapi commented Aug 16, 2022

Looks good, but UX-wise: without the video, I wouldn't notice the "Toggle element toolbar" button - let's talk about it on the design sync.

@miina miina marked this pull request as ready for review August 17, 2022 14:37
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 17, 2022

Plugin builds for 749e6f1 are ready 🛎️!

PR feedback
@miina miina requested a review from merapi August 17, 2022 14:48
@miina
Copy link
Contributor Author

miina commented Aug 17, 2022

This is now ready -- only waiting for UX to switch the Toolbar icon + update the copy.

Copy link
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I 🕺 this!

Copy link
Contributor

@merapi merapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

I centered the icon.

@miina miina merged commit a7d742e into main Aug 29, 2022
@miina miina deleted the add/11570-floating-menu-position branch August 29, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating Menu: Consider ability to disable or change the default positioning
4 participants