Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message when Autosave exists #12098

Merged
merged 14 commits into from
Aug 23, 2022
Merged

Add message when Autosave exists #12098

merged 14 commits into from
Aug 23, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Aug 12, 2022 •
edited by swissspidy

Context

Add autosave message to story if available to match the WordPress flow

Summary

Adds autosave message when there's an autosave available.

Screen Shot 2022-08-12 at 6 10 59 AM

Screen Shot 2022-08-12 at 6 11 41 AM

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #3841

@timarney timarney self-assigned this Aug 12, 2022
@timarney timarney added Group: Editing Main editing features Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar Pod: WP Type: Enhancement New feature or improvement of an existing feature labels Aug 17, 2022
@timarney timarney changed the title WIP - Add message when Autosave exists Add message when Autosave exists Aug 17, 2022
@timarney timarney marked this pull request as ready for review August 22, 2022 10:21
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 22, 2022 •
edited

Plugin builds for 5898d28 are ready 🛎️!

@swissspidy swissspidy requested review from miina and removed request for spacedmonkey August 22, 2022 13:44
swissspidy
swissspidy reviewed Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, but needs the isDraft check to be removed in AutoSaveHandler to actually create an autosave with the right format.

Can we do that in this PR?

packages/story-editor/src/components/autoSaveCheck/autoSaveDialog.js Outdated Show resolved Hide resolved
packages/story-editor/src/components/autoSaveCheck/autoSaveDialog.js Show resolved Hide resolved
@swissspidy
Copy link
Collaborator

Works well, but needs the isDraft check to be removed in AutoSaveHandler to actually create an autosave with the right format.

Can we do that in this PR?

Actually, I suppose #1402 is for doing that.

timarney and others added 4 commits August 22, 2022 12:47
@timarney @swissspidy
Update packages/story-editor/src/components/autoSaveCheck/autoSaveDia…
66827a4 
…log.js

Co-authored-by: Pascal Birchler <pascalb@google.com>
@timarney @miina
Update packages/story-editor/src/components/autoSaveCheck/autoSaveDia…
5115214 
…log.js

Co-authored-by: Miina <miina.sikk@gmail.com>
@timarney @miina
Update packages/story-editor/src/components/autoSaveCheck/autoSaveDia…
7a4aa34 
…log.js

Co-authored-by: Miina <miina.sikk@gmail.com>
@timarney
check feature
abe5ac3
@swissspidy
Copy link
Collaborator

Merging now; QA can be done in #1402 when it becomes actually user-facing.

@swissspidy swissspidy merged commit c8f663e into main Aug 23, 2022
@swissspidy swissspidy deleted the fix/3841-auto-save-link branch August 23, 2022 09:25
@swissspidy swissspidy mentioned this pull request Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@miina miina miina approved these changes

Assignees

@timarney timarney

Labels
Group: Editing Main editing features Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add message when Autosave exists
4 participants
@timarney @googleforcreators-bot @swissspidy @miina