Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery: always print document title #12162

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Conversation

swissspidy
Copy link
Collaborator

Context

It was reported that there was a missing <title> tag on stories when using Yoast SEO in combination with a block theme like Twenty Twenty Two

Summary

Adds a separate function with its own filter for displaying the document title.

Ensures that the document title is always printed when using SEO plugins and a block theme.

Relevant Technical Choices

To-do

User-facing changes

No changes besides the <title> tag reappearing.

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. Activate Yoast SEO plugin
  2. Activate Twenty-Twenty Two theme
  3. View a single story
  4. Verify the <title> tag is added

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #12139

Adds a separate function with its own filter for displaying the document title.

Ensures that the document title is always printed when using SEO plugins and a block theme.
@swissspidy swissspidy added Type: Bug Something isn't working Group: Discoverability Group: Integration Integration with other platforms and plugins PHP Pull requests that update PHP code Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP labels Aug 23, 2022
@googleforcreators-bot
Copy link
Collaborator

Plugin builds for dc91e68 are ready 🛎️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Discoverability Group: Integration Integration with other platforms and plugins Group: WordPress Changes related to WordPress or Gutenberg integration PHP Pull requests that update PHP code Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEO: <title> tag removed when using SEO plugin and block theme
3 participants