Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: enable a few useful ESLint rules #12165

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

swissspidy
Copy link
Collaborator

Context

Related to #12086

Summary

While the solutions mentioned on that ticket are a bit outdated and not super useful for us, I was able to steal a couple of useful ESLint rules from them for our project.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #

@swissspidy swissspidy added Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: WP labels Aug 24, 2022
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 24, 2022

Plugin builds for bcc4530 are ready 🛎️!

Copy link
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unit tests are failing now on this PR.

.eslintrc Show resolved Hide resolved
@swissspidy swissspidy requested a review from miina August 25, 2022 07:29
@swissspidy swissspidy merged commit d2faae7 into main Aug 25, 2022
@swissspidy swissspidy deleted the fix/12086-eslint-stricter-rules branch August 25, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants