Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert moveable package to TypeScript #12169

Merged
merged 10 commits into from
Sep 1, 2022
Merged

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Aug 26, 2022

Context

Summary

Relevant Technical Choices

  • Defined the styled-components theme with TS.
  • Added some custom type definitions under packages/moveable/src/typings (see to-do below)

To-do

Help needed with these:

  • Fix any bugs
  • Fix remaining type error when passing a ref to OriginalMoveable
  • Figure out a solution so we can move packages/moveable/src/typings/*.d.ts to top-level typings/ folder instead. Otherwise it's a bit messy.

User-facing changes

N/A

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #12088

@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Package: Moveable /packages/moveable labels Aug 26, 2022
@swissspidy swissspidy requested a review from miina August 26, 2022 13:59
@swissspidy swissspidy changed the title [WIP] Convert moveable package to TypeScript Convert moveable package to TypeScript Aug 29, 2022
@swissspidy swissspidy marked this pull request as ready for review August 29, 2022 17:44
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 29, 2022

Plugin builds for 4a2f3d2 are ready 🛎️!

swissspidy and others added 3 commits August 31, 2022 11:03
It seems that the ref inside moveable is a ref to the component instance itself and not to an HTML element or even the manager object.
@swissspidy swissspidy removed the request for review from spacedmonkey September 1, 2022 13:02
@swissspidy swissspidy changed the title Convert moveable package to TypeScript Convert moveable package to TypeScript Sep 1, 2022
@swissspidy
Copy link
Collaborator Author

Last lint error fixed, this should now be ready again.

@swissspidy swissspidy mentioned this pull request Sep 1, 2022
@swissspidy swissspidy merged commit 7ffe80d into main Sep 1, 2022
@swissspidy swissspidy deleted the fix/12088-typescript-moveable branch September 1, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Moveable /packages/moveable Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript: Convert moveable package
4 participants