Convert transform package to TypeScript
#12202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
commented
Sep 1, 2022
| [id: string]: Record<string, unknown> | null; | ||
| } | ||
|
|
||
| export interface State { |
There was a problem hiding this comment.
@swissspidy Do you happen to have a good example of creating a context with actions and state that I could check? Not sure exactly how to do this here, had to use type casting which doesn't seem right here. Or is this an example of the useContextSelector that might still need work (since it's all related to that, and has to match the typing of the context selector)?
There was a problem hiding this comment.
So far I only attempted this in packages/units/src/context.ts / packages/units/src/contextProvider.tsx but yeah it still needs some work to get type support when using useContextSelector.
This might do the trick though:
https://github.com/GoogleForCreators/web-stories-wp/tree/try/fix-context-state
This way I get type support when doing something like
useUnits(({ state: { pageSize } }) => pageSize);There was a problem hiding this comment.
Hm, not sure if I did something incorrectly but I still have to assign types in the provider for it not to throw errors.
miina
added
Type: Code Quality
miina
requested review from
barklund and
merapi
and removed request for
spacedmonkey
|
Plugin builds for c1c5ff1 are ready 🛎️!
|
swissspidy
reviewed
Sep 2, 2022
|
Size Change: +2 B (0%) Total Size: 2.68 MB
ℹ️ View Unchanged
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Converts
transformpackage to TypeScriptSummary
Relevant Technical Choices
To-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12173