TypeScript: Migrate migration package
#12320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
added
Type: Infrastructure
miina
commented
Sep 15, 2022
added 2 commits
September 15, 2022 20:45
# Conflicts: # packages/patterns/src/generatePatternStyles.ts
miina
commented
Sep 29, 2022
| @@ -55,7 +55,7 @@ describe('setOpacity', () => { | |||
| elements: [ | |||
| { | |||
| _test: 'element1', | |||
| opacity: 100, | |||
| opacity: 0, | |||
There was a problem hiding this comment.
Opacity was set but 0 so it should stay as it was.
miina
commented
Sep 29, 2022
| }, | ||
| { | ||
| _test: 'element2', | ||
| type: 'text', | ||
| backgroundColor: 'transparent', |
There was a problem hiding this comment.
Background color can't be transparent at this point, it was migrated to Pattern in V6
miina
commented
Sep 29, 2022
| src: 'https://example.com/audio.mp3', | ||
| id: 123, | ||
| mimeType: 'audio/mpeg', | ||
| resource: { |
There was a problem hiding this comment.
Story background audio was migrated to have resource in V39.
miina
commented
Sep 29, 2022
|
|
||
| function updateElement(element: UnionElementV6): UnionElementV7 { | ||
| // If it's a text element or already has flip set, return as is. | ||
| if ('content' in element || 'flip' in element) { |
There was a problem hiding this comment.
Not sure if there's a better way for TS to understand it's a text element, so using 'content' in element since that's unique to text element at this point.
|
Plugin builds for 7a94718 are ready 🛎️!
|
|
Size Change: +276 B (0%) Total Size: 2.71 MB
ℹ️ View Unchanged
|
miina
commented
Sep 29, 2022
miina
commented
Sep 29, 2022
miina
commented
Sep 29, 2022
packages/migration/src/migrate.ts
Outdated
| import removeTagNames from './migrations/v0043_removeTagNames'; | ||
|
|
||
| const MIGRATIONS = { | ||
| const MIGRATIONS: Record<number, any[]> = { |
There was a problem hiding this comment.
Still don't have a solution for a generic MigrationFn type (instead of any[]). Any (non-any 😛 ) ideas are appreciated.
There was a problem hiding this comment.
It's a tough one. Unfortunately the article Morten shared before doesn't really cover that for a case like ours.
I've briefly looked into using union types here or something else clever, but couldn't find a nice way for it.
Soo... maybe we just use any for now until we find something better? 🙈
barklund
approved these changes
Oct 3, 2022
|
Merging with failing Karma tests since those are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
migrate.tsfile'smigrationFnneeds figuring outPageV[X]andStoryV[X]types.User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12239