Media: Clean up linked post meta on attachment deletion #12321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Group: Media
Group: WordPress
|
Plugin builds for 9e34261 are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
swissspidy
changed the title
web_stories_muted_id not cleaned up on attachment deletion
|
Can we do The only difference is that this works on all post types, not just attachments. But since these are prefixed meta keys that ar only used by us and only for attachments, that's OK. This will greatly simplify the code and we don't have to establish a |
spacedmonkey
force-pushed
the
fix/clear-post-meta
branch
from
7bd9853
to
3d81066
Compare
I always for forget about that with the metadata api. That is way simpler. I have pushed a change to be do this. |
swissspidy
approved these changes
Sep 16, 2022
|
Error Reproduction: I recreated the issue in Bug Fix: I switched over to
|
|
Permutations: In order to test around other media clean up events, I added background audio and then deleted the original file, to confirm there are no side effects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If you delete a muted / optimized version of a video, also delete the post meta to link to the original video.
Summary
Relevant Technical Choices
I created a util class so that the code can be shared. I thought about an abstract and traits to share code. A util class is what I needed up with.
I would like to avoid doing a meta query, but I can't think of a way around it, other than a raw database query.
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12240