Background Audio: fix types and link conflict #12407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
spacedmonkey
approved these changes
Sep 30, 2022
timarney
approved these changes
Oct 3, 2022
|
Plugin builds for af799aa are ready 🛎️!
|
|
ReCreated this issue on
Verified the fix using test web-story
Permutations:
|
This is expected behavior.
This is expected behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Non-looping background audio clashed with link elements on a page.
Also, because of a type bug, the
lengthwas not passed when saving background audio, causing the "Loop" control to not be displayed.Summary
<amp-video>element was overlaying any links, making links not clickable.Relevant Technical Choices
Extended e2e test to cover the "Loop" control
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12384