Autosaves: delete local auto-draft autosave after save #12417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 8411470 are ready 🛎️!
|
|
Size Change: +45 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
barklund
reviewed
Oct 3, 2022
packages/story-editor/src/components/localAutoSaveHandler/localAutoSave.js
Outdated
Show resolved
Hide resolved
barklund
approved these changes
Oct 4, 2022
|
@miina @swissspidy - When I loaded the Upon creating a new story: Within the debugger: So I cannot test this ticket with the changes in Q: Could you help me get a better build made without this problem ? |
|
Please try again now. The PR is updated now and should not have this bug anymore. |
|
@miina @swissspidy - I can confirm that the So the sequence I observed was:
NOW the
I was expecting the Q: Could you confirm this sequence is ok ? |
|
In addition, I would like to flag a regression: When the Steps
ISSUE: A blank story is created This is working as expected on Cc: @miina |
@kkalarickal Yes, that's ok, thanks for checking. Since the saved version is also stored in the database then there's no need for an older local backup. |
Confirmed the issue and should be fixed now as well, could you test again? |
|
Confirmed that the There are some more scenarios around take over and auto-saved session objects ... but those are unrelated to this ticket. I will file them separately. @miina @swissspidy - this ticket can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
wp_stories_autosave_story_auto-draftgets createdwp_stories_autosave_story_12345gets createdwp_stories_autosave_story_auto-draftis discarded at this pointReviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12342