TypeScript: migrate templates package
#12429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
added
Type: Code Quality
miina
commented
Oct 4, 2022
miina
commented
Oct 5, 2022
swissspidy
reviewed
Oct 6, 2022
miina
commented
Oct 7, 2022
|
Plugin builds for f1599af are ready 🛎️!
|
|
Size Change: -52 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
miina
commented
Oct 7, 2022
| isDefaultBackground?: boolean; | ||
| type: ElementType.Shape; | ||
| // TODO(#12437): Figure out why shape elements end up having these properties & fix it. |
There was a problem hiding this comment.
Added #12437 to track this
barklund
approved these changes
Oct 10, 2022
barklund
reviewed
Oct 10, 2022
Comment on lines
+22
to
+24
| type Data = { | ||
| default: MetaData; | ||
| }; |
There was a problem hiding this comment.
Why define this here?
There was a problem hiding this comment.
Because it's very specific to this one function here only, in this case, adding it next to the function has been a common practice for readability across the project so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12176