Fix missing images in Safari #12461
Merged
Fix missing images in Safari #12461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
Plugin builds for fb8c14b are ready 🛎️!
|
|
I tested it on different machines/versions and it looks like the issue is fixed, PTAL. Upstream fix: bubkoo/html-to-image#325 |
spacedmonkey
approved these changes
Oct 12, 2022
barklund
approved these changes
Oct 12, 2022
miina
approved these changes
Oct 12, 2022
We can now (probably) remove all |
|
@merapi - i tested this on Safari 15.3 and Safari 14.1.2 (passed) and also tried 13.1.2 (failed) Test story had all allowed image and video files, along with stickers, links, and other embeds to create a complex set of pages that were then checked within Safari/Chrome browsers to veify pre/next buttons showed the proper images on the editor window. For Safari 13.1.2 there was a problem loading the web stories editor Overall, the tiles are now visible on past two versions of Safari. It was not visible on these versions when using the main branch. |
|
@merapi - I think I found a regression in the cropping workflow when adding a link to an image. Steps: <On Safari only, with
ISSUE: An error is reported while cropping the image I tried the same steps on Safari using |
We don't support Safari 13, so this is OK. In general our policy is to only support the last 2 major versions of a browser. See |
@kkalarickal I tested it on Safari 14 and had no issues (maybe it was a temporary issue with loading resources). |
|
Agree @merapi .... now I can do the cropping without any issues. passing this ticket for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This bug was pretty inconsistent, some images worked, some not, sometimes those which worked didn't work and so on.
I noticed that external pictures were not working more often.
The issue occurs somewhere between SVG and PNG generation:
SVG:
PNG:
Last time we fixed the Safari pictures by setting
decoding=syncon images.The current issue can be replicated in even a very old version (from January) so apparently we didn't fix all of the Safari issues last time.
I did a full circle and I'm back to image decoding.
I'm testing if explicit
Image.decode()will fix the issue (it looks like so far).https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12432