Improve calendar styling #12481
Merged
Improve calendar styling #12481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Enhancement
|
Plugin builds for c36e551 are ready 🛎️!%0A- Download development build%0A- Download production build |
|
Size Change: -383 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
miina
reviewed
Oct 17, 2022
Good call. Improved the contrast now. |
|
Plugin builds for b0710ce are ready 🛎️!%0A- Download development build%0A- Download production build |
miina
approved these changes
Oct 17, 2022
|
@swissspidy - there seems to be a different color for current date vs the selected date which is lost with the changes in this ticket. For example, consider a story with publish data 01-Nov-2022. This is different from today's date of 17-Oct-2022 In the However, with the changes in Similarly, when you go one level higher by clicking the Month-Year title, you can see that in But in Since this is a ticket for consistent calendar styling, these color changes for present vs selected dates should probably be fixed. |
Not technically :-) Well, on hover they were similar, but otherwise the current date has a gray bg:
Good catch 👍 Fixed now:
|
|
Plugin builds for 49d9d28 are ready 🛎️!%0A- Download development build%0A- Download production build |
|
Confirmed that the current date/month/year appears in a grey box when the published date/month/year is different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It has always bugged me that our date picker's styling does not match the rest of the editor.
Summary
Updates the date/time picker in the editor to better match the rest of the app.
Relevant Technical Choices
To-do
User-facing changes
Before
After
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #1391