Infrastructure: Revert platform check #12484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
|
Plugin builds for ef2f1b8 are ready 🛎️!
|
spacedmonkey
force-pushed
the
fix/composer-fix-1
branch
from
d3131cc
to
7b6f022
Compare
spacedmonkey
force-pushed
the
fix/composer-fix-1
branch
from
3dcdb6d
to
b7a78f8
Compare
swissspidy
reviewed
Oct 18, 2022
spacedmonkey
commented
Oct 18, 2022
|
Converting this to a draft just so we don't needlessly create Percy snapshots during development. |
spacedmonkey
added
Type: Infrastructure
spacedmonkey
changed the title
swissspidy
changed the title
swissspidy
reviewed
Oct 18, 2022
swissspidy
reviewed
Oct 18, 2022
swissspidy
reviewed
Oct 18, 2022
swissspidy
reviewed
Oct 18, 2022
Co-authored-by: Pascal Birchler <pascalb@google.com>
swissspidy
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Download
php-scoper-wordpress-excludespackage, as the min requirement for that package is PHP 7.4. Also remove platform requirements for composer update in GitHub action.Doing this work as meant that I had to update composer and install updated packages. This meant that I had to fix
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #