Remove fontWeight and backgroundOverlay from element properties
#12511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
added
Type: Code Quality
miina
commented
Oct 19, 2022
| function updateElement(element: UnionElementV43): UnionElementV44 { | ||
| if ('fontWeight' in element) { | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment -- Removes lingering properties that came from the templates but don't exist on the type. | ||
| // @ts-ignore -- Ignore fontWeight not existing on element. |
There was a problem hiding this comment.
Not sure if there's an alternative to just ignoring the type error here -- the error is correct, the type does not include these props anymore, however, since we still got them from the templates somehow, then these do exist in some cases.
|
Size Change: +32 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
|
Plugin builds for 5266301 are ready 🛎️!
|
swissspidy
approved these changes
Oct 19, 2022
spacedmonkey
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Removes
fontWeightandbackgroundOverlayfrom the element properties. These have been removed before in migrations as well, however, looks like were added again via templates.Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12258