Avoid always loading RTL stylesheets #12552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Bug
|
Plugin builds for de3026f are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.71 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I just noticed that we were loading the RTL variants of our stylesheets all the time, even when viewing the LTR version.
So on LTR, we were loading two stylesheets: first the RTL version, then LTR.
As a user you don't notice it because the LTR one overrides the former.
Summary
Avoid always loading RTL stylesheets, even on LTR.
Adjusts webpack config to prevent duplicate stylesheets.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
wp-dashboard-cssis loaded, butwp-dashboard-rtl-cssis notwp-dashboard-rtl-cssis loadedReviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #