Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworking the elements package #12557

Merged
merged 26 commits into from
Nov 11, 2022
Merged

Reworking the elements package #12557

merged 26 commits into from
Nov 11, 2022

Commits on Oct 12, 2022

  1. Moved types around and converted elements package

    Morten Barklund committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    e573e07 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. WIP: convert element-library package

    Morten Barklund committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    cb1e0f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Merge branch 'main' into code/12126-ts-elements 

    # Conflicts:
#	package-lock.json
#	packages/elements/src/elementType.js
#	packages/elements/src/elementType.ts
#	packages/elements/src/types.js
#	packages/elements/src/types.ts
#	packages/elements/src/types/element.ts
#	packages/elements/src/types/page.ts
#	packages/elements/src/types/propTypes.ts
#	packages/elements/src/utils/createNewElement.ts
#	packages/elements/src/utils/createPage.ts
#	packages/elements/src/utils/duplicateElement.ts
#	packages/elements/src/utils/duplicatePage.ts
#	packages/elements/src/utils/getElementOffsets.ts
#	packages/elements/src/utils/getElementOrigin.ts
#	packages/elements/src/utils/getLayerName.ts
#	packages/elements/src/utils/getTransformFlip.ts
#	packages/elements/src/utils/isElementBelowLimit.ts
#	packages/elements/tsconfig.json
#	packages/migration/package.json
#	packages/templates/src/raw/a-day-in-the-life/index.ts
#	packages/units/src/context.ts
#	packages/units/src/dimensions.ts
#	packages/units/src/getBoundRect.ts
#	packages/units/src/types.ts
#	tsconfig.json
    Morten Barklund committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9ec518c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Re-moved types to relevant packages and untyped the element-library

    Morten Barklund committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    7630dd8 View commit details
    Browse the repository at this point in the history

  2. Updating package.json

    Morten Barklund committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    494346a View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Merge branch 'main' into code/12126-ts-elements

    Morten Barklund committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    991345d View commit details
    Browse the repository at this point in the history

  2. Feedback improvements

    Morten Barklund committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    28b0c3b View commit details
    Browse the repository at this point in the history

  3. Fixed more from PR feedback

    Morten Barklund committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    9b477f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into code/12126-ts-elements

    Morten Barklund committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    97c27ad View commit details
    Browse the repository at this point in the history

  5. Fix lint error

    Morten Barklund committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    fd60e59 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Merge branch 'main' into code/12126-ts-elements

    Morten Barklund committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    f3453d3 View commit details
    Browse the repository at this point in the history

  2. Moved element definitions to element library package and updated depe… 

    …ndencies
    Morten Barklund committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    0167906 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Fixed React-17 React.FC issue and resource id reference

    Morten Barklund committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    1e3577e View commit details
    Browse the repository at this point in the history

  2. Removed Page.type property as it is redundant 

    Also fixed a test.

Note that there are many more instance of type:"page" in the code, but most are related to tests that will probably still work fine or templates, which will also work fine with an extra unused property. Should we add a migration though?
    Morten Barklund committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    e2d875a View commit details
    Browse the repository at this point in the history

  3. Fix imports of background audio prop type

    Morten Barklund committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    b6b027e View commit details
    Browse the repository at this point in the history

  4. Fixed a karma test

    Morten Barklund committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    0ad2e73 View commit details
    Browse the repository at this point in the history

  5. Finally fixed that annoying bg-shape-element copy thingy

    Morten Barklund committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    14e9261 View commit details
    Browse the repository at this point in the history

  6. Added a comment to make sense of it

    Morten Barklund committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    fadc9c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Fix eyedropper

    @merapi
    merapi committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    677a1c6 View commit details
    Browse the repository at this point in the history

  2. Target correct element

    @merapi
    merapi committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    eab2ba6 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge branch 'main' into code/12126-ts-elements 

    # Conflicts:
#	tsconfig.json
    Morten Barklund committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8fc7db7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/code/12126-ts-elements' into cod… 

    …e/12126-ts-elements
    Morten Barklund committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    64d50de View commit details
    Browse the repository at this point in the history

  3. Updated type references for config providers

    Morten Barklund committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c72cc07 View commit details
    Browse the repository at this point in the history

  4. Missing types in package.json?

    Morten Barklund committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1d951d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge branch 'main' into code/12126-ts-elements 

    # Conflicts:
#	packages/media/src/createResource.ts
#	packages/media/src/types/propTypes.ts
#	packages/wp-story-editor/src/api/utils/normalizeResourceSizes.js
    Morten Barklund committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    255d5f6 View commit details
    Browse the repository at this point in the history

  2. Reorganized data types to elements package

    Morten Barklund committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    f1e7468 View commit details
    Browse the repository at this point in the history