Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests: Run against WordPress 5.9+ #12606

Merged
merged 11 commits into from
Nov 3, 2022
Merged

E2E Tests: Run against WordPress 5.9+ #12606

merged 11 commits into from
Nov 3, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Nov 1, 2022

Context

Update E2E test to run 5.9 as min version

Summary

Updates workflow file

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. verify e2e test pass as per current main branch

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #12572

@timarney timarney self-assigned this Nov 1, 2022
@timarney timarney added Package: E2E Tests /packages/e2e-tests Pod: WP Type: Infrastructure Changes impacting testing infrastructure or build tooling Type: Task Tasks which do not involve engineering labels Nov 1, 2022
@timarney
Copy link
Contributor Author

timarney commented Nov 2, 2022

@swissspidy @spacedmonkey --- seems like most of the remaining failures for this PR are for the WooCommerce tests any thoughts as to why?

Bumped minWPVersionRequired('5.9'); // WooCommerce requires WP 5.7+ but that didn't fix in this case

@spacedmonkey
Copy link
Contributor

What about -

@swissspidy
Copy link
Collaborator

@spacedmonkey There's a separate ticket for changing the unit tests.

@swissspidy
Copy link
Collaborator

@swissspidy @spacedmonkey --- seems like most of the remaining failures for this PR are for the WooCommerce tests any thoughts as to why?

Bumped minWPVersionRequired('5.9'); // WooCommerce requires WP 5.7+ but that didn't fix in this case

@timarney Because WooCommerce is not being installed on the WP 5.9 tests.

In install-wordpress.sh you can see it's only being installed when using latest. But now we need to change it to always install WooCommerce.

@timarney timarney marked this pull request as ready for review November 2, 2022 12:45
@swissspidy
Copy link
Collaborator

FYI, looks like the WP latest e2e tests are not passing because the twentytwenty theme could not be found, because it's not recent enough.

WP only ships three default themes, so with 6.1 it's twentytwentyone, twentytwentytwo and twentytwentythree

To fix, we need to force-install the theme. So we need to change this line:

wp theme activate twentytwenty --quiet

Into wp theme install twentytwenty --activate --force --quiet

@swissspidy swissspidy merged commit 5200888 into main Nov 3, 2022
@swissspidy swissspidy deleted the fix/12572-e2e-tests branch November 3, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: E2E Tests /packages/e2e-tests Type: Infrastructure Changes impacting testing infrastructure or build tooling Type: Task Tasks which do not involve engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Tests: Run against WordPress 5.9+
3 participants