Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests only against PHP 7.4+ #12607

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Run unit tests only against PHP 7.4+ #12607

merged 3 commits into from
Nov 2, 2022

Conversation

spacedmonkey
Copy link
Contributor

Context

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #12574

@spacedmonkey spacedmonkey added Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP labels Nov 2, 2022
@spacedmonkey spacedmonkey self-assigned this Nov 2, 2022
@swissspidy
Copy link
Collaborator

Note that there‘s a separate ticket for the WP 5.9 change

@swissspidy swissspidy merged commit 4559efe into main Nov 2, 2022
@swissspidy swissspidy deleted the fix/php-7-4 branch November 2, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

@timarney timarney Awaiting requested review from timarney

Assignees

@spacedmonkey spacedmonkey

Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run unit tests only against PHP 7.4+
2 participants
@spacedmonkey @swissspidy