Fix Story Duration Default #12645
Merged
Fix Story Duration Default #12645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 24d5dc1 are ready 🛎️!
|
|
Size Change: +147 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
@merapi - I checked out this PR per your go ahead, using the A few observations that might be worth confirming:
Can you confirm this behavior is ok ? |
|
Thanks for testing. I think I rushed with the decimals part, we will discuss it further. |
I'm ok with that, it is consistent with other non-decimal fields. Pascal is also ok: #12599 (comment) |
merapi
force-pushed
the
fix/12600-page-adv-revert
branch
from
cb7040e
to
81baf06
Compare
swissspidy
reviewed
Nov 8, 2022
packages/story-editor/src/components/panels/shared/generalPageAdvancement.js
Outdated
Show resolved
Hide resolved
swissspidy
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a few issues listed at the bottom.
For #12599 I tried to use snackbar, but because the min/max logic is inside the input component that might be too invasive.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12600
Fixes #12599
Fixes #12644