Fix rollup config and address warnings #12682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Infrastructure
Reduces number of files using named and default exports together. Consumers of your bundle will have to use `chunk['default’]` to access their default export, which is error prone and confusing. Also de-dupes date-fns versions.
swissspidy
force-pushed
the
fix/rollup
branch
from
8ea4441
to
6520266
Compare
|
Size Change: -1.07 kB (0%) Total Size: 2.71 MB
ℹ️ View Unchanged
|
32 tasks
swissspidy
added a commit
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces number of files using named and default exports together.
Consumers of your bundle will have to use
chunk['default’]to access their default export, which is error prone and confusing.Also de-dupes date-fns versions.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #