Block: Fix issues with rearranging stories in Firefox #12708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timarney
added
Browser Issues
Group: Blocks
|
Plugin builds for bc438c8 are ready 🛎️!
|
|
Size Change: +30 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
@timarney Is this ready for review? Please request reviews if that's the case |
Yes it's ready - not sure why the end to end test is failing --- looking at the artifacts and given this is a one line CSS update it seems unrelated. |
Fixes issue with rearranging and selection
|
This fixes the rearranging, but breaks the story selection, because the Pushing some change now to work around that, let's see if it works |
swissspidy
approved these changes
Nov 28, 2022
|
Re-tested seems to work the same as main but with the dragging working. I did notice on both main and this branch when selecting a story --- you can click the cover image to select but need to click the "icon" (check or remove) to deselect. Works the same on main. |
|
Confirmed the ability to select and rearrange stories within the web-stories block on : Firefox, Chrome, Opera, Safari, Edge browsers. I also confirmed that clicking the cover image selects the story but to de-select user needs to click the check box specifically. This happens for all browsers. The main UI difficulty I encountered while rearranging the stories was that if there are several rows of stories, then dragging a story tile from the bottom to the top was not easy. The auto scroll of the overlay was super difficult to trigger and it took me several attempts to rearrange the bottom most story tile to the top row (i had to rearrange it row by row). Cc: @swissspidy @timarney |
|
Thanks for testing @kkalarickal Feel free to create an enhancement ticket for that rearranging difficulties |
swissspidy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
From #12649:
On firefox, the rearrange overlay did not allow me to move the stories by clicking on the cover image !! I could onlu rearrange when I dragged the title area ...
Plugin Version: 1.27.0
WordPress Version: 6.1
Operating System:
Browser: Firefox
Summary
Updates CSS for
web-stories-story-preview-card__overlaymaking it relative vs absoluteSee:
Testing in Chrome and Firefox
👉 https://www.youtube.com/watch?v=EXu6hDamKBw
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12703