Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS: Implement StaticClosure rule #12908

Merged
merged 2 commits into from Jan 9, 2023
Merged

PHPCS: Implement StaticClosure rule #12908

merged 2 commits into from Jan 9, 2023

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey commented Jan 9, 2023

Context

Summary

Implement SlevomatCodingStandard.Functions.StaticClosure rule.
This rule reports closures not using $this that are not declared static.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

See #12729

@spacedmonkey spacedmonkey self-assigned this Jan 9, 2023
@spacedmonkey spacedmonkey added the Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ label Jan 9, 2023
phpcs.xml.dist Outdated Show resolved Hide resolved
@swissspidy swissspidy changed the title Implement StaticClosure rule. PHPCS: Implement StaticClosure rule Jan 9, 2023
@swissspidy swissspidy merged commit 1898c43 into main Jan 9, 2023
@swissspidy swissspidy deleted the StaticClosure branch January 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants