E2E Tests: Disable access to remote block directory and patterns #12935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Infrastructure
They often cause block validation console errors on older WordPress version
swissspidy
force-pushed
the
fix/e2e-tests
branch
from
4ef36ad
to
272629e
Compare
|
Plugin builds for cf17809 are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.71 MB ℹ️ View Unchanged
|
swissspidy
changed the title
swissspidy
changed the title
|
@spacedmonkey FYI, removed Airplane Mode again because it caused too many tests to fail, for example around media hotlinking or when using the AMP CDN (Web Stories block, AMP validator) |
swissspidy
commented
Jan 19, 2023
| @@ -41,7 +41,7 @@ | |||
| * | |||
| * @param bool $network_wide Whether to activate network-wide. | |||
| */ | |||
| function activate( bool $network_wide = false ): void { | |||
| function activate( ?bool $network_wide = false ): void { | |||
There was a problem hiding this comment.
Changed this because it's not always a bool, e.g. when activating a plugin via WP-CLI.
swissspidy
commented
Jan 19, 2023
Comment on lines
+49
to
+50
| '<rootDir>/packages/e2e-tests/node_modules/@wordpress/jest-puppeteer-axe', | ||
| '<rootDir>/packages/e2e-tests/node_modules/@wordpress/jest-console', |
There was a problem hiding this comment.
Since these packages are not always in the node_modules folder in the root folder (because of npm workspaces), this is the way.
|
Those timeouts are not great 😕 No idea why tests suddenly take that long... |
|
Timeout is not resolved yet, but merging to unblock other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
They often cause block validation console errors on older WordPress version. This currently causes our e2e tests against WP 5.9 to fail.
Summary
Disable access to remote block directory and patterns
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #