Code Quality: Dynamically import mediainfo.js #12954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Group: Media
Type: Performance
|
Plugin builds for a9beb07 are ready 🛎️!
|
|
Size Change: +13 kB (0%) Total Size: 2.7 MB
ℹ️ View Unchanged
|
spacedmonkey
approved these changes
Jan 23, 2023
|
This is good to merge. Are we merging before the next release? |
|
@spacedmonkey waiting for QA |
|
cc @kkalarickal |
|
@swissspidy @spacedmonkey - I tested media upload on using
The basic workflows all seem to work as expected. I did run into a crash on the video recording workflow though: Trying to recrate it consistently. |
|
That might be a new issue, but not sure. Would need to try to recreate myself to see the exact cause of error. |
|
Don't see any issues with video trimming. Warrants a new issue if it persists. |
|
I could not recreate the crash again after multiple attempts. It needs a new ticket if it occurs again after merge on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #