Media: Convert HEIF images to WebP/JPEG #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Enhancement
|
Plugin builds for a88ab7b are ready 🛎️!
|
|
Size Change: +532 B (0%) Total Size: 2.7 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Photos taken on iPhone typically have an
.heicfile extension. The HEIF/HEIC image format is great because it's super small, but it's not supported by any browsers.Summary
This change implements HEIC image decoding via
a simple web workera script that loads libheif-js from an external script that then converts the image to WebP via Canvas.Safari does not support WebP in Canvas though, so there it falls back to JPEG.
Relevant Technical Choices
libheif-jsuses LGPL 3.0, which is why we don't bundle it in the plugin but instead load it dynamically.We can't use it in a worker because of cross-origin isolation limitations.
So the whole decoding happens in the main thread. In my testing it was usually quite fast, so probably not a big deal.
To-do
libheif-jsfrom CDNUser-facing changes
Screen.Recording.2023-02-13.at.17.56.10.mov
Testing Instructions
This PR can be tested by following these steps:
I used some from https://github.com/alexcorvi/heic2any/tree/master/demo
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
libheif-jsuses LGPL 3.0, which is why we don't bundle it in the plugin but instead load it dynamically.Checklist
Type: XYZlabel to the PRFixes #8292