Editor: Update behavior of consecutive snackbars #13190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushnirwal
changed the title
ayushnirwal
added
Group: Workspace
|
Size Change: -32 B (0%) Total Size: 2.73 MB ℹ️ View Unchanged
|
|
Plugin builds for 3c34bea are ready 🛎️!
|
swissspidy
reviewed
Apr 25, 2023
packages/design-system/src/components/snackbar/snackbarContainer.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+45
to
+53
| | Pick<SnackbarNotification, 'id'> | ||
| | Pick<SnackbarNotification, 'id'>[] | ||
| ) => { | ||
| setNotifications((currentNotifications) => | ||
| currentNotifications.filter((item) => { | ||
| if (Array.isArray(toRemove)) { | ||
| return !toRemove.find(({ key }) => key === item.key); | ||
| return !toRemove.find(({ id }) => id === item.id); | ||
| } | ||
| return item.key !== toRemove.key; | ||
| return item.id !== toRemove.id; |
There was a problem hiding this comment.
key is actually used in at least one place:
web-stories-wp/packages/story-editor/src/app/media/useUploadMedia.js
Lines 106 to 116 in be47067
Should we just remove key there because we only show 1 notification now anyway?
If so, we should probably remove key entirely from the SnackbarNotification type.
There was a problem hiding this comment.
instead of using key here we can pass id in showSnackbar. This will overwrite the default id given using uuid.
In case we want to show more than one snack bar in the future, notifications can be still deleted using removeSnakbar and a known id.
swissspidy
changed the title
swissspidy
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Updates consecutive snack bar behavior to be more inline with Material design guidelines
Summary
SnackbarProvider'sremovefunction was removing notifications on the basis ofkeywhich was not a valid key. This was causing all snack bars to be removed when thenotificationslist hit its max limit.SnackbarContainerwhich was causing enter animation not to apply.SnackbarContainerto show only one snack bar at a time.Relevant Technical Choices
To-do
User-facing changes
Before -
Screen.Recording.2023-04-10.at.2.10.48.PM.mov
After -
Screen.Recording.2023-04-10.at.2.08.01.PM.mov
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12845