Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-moveable from 0.39.6 to 0.49.2 #13217

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Bump react-moveable from 0.39.6 to 0.49.2 #13217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f05292
Bump react-moveable from 0.39.6 to 0.49.2
dependabot[bot] Apr 17, 2023
7063ced
remove patch for react moveable
ayushnirwal Apr 20, 2023
712d408
delay adding next element by forcing it in the back of the queue
ayushnirwal Apr 24, 2023
f6a2880
revert click handelling in multi moveable
ayushnirwal Apr 25, 2023
e3c366f
update type patch
ayushnirwal Apr 26, 2023
f4958ff
hack fix
ayushnirwal Apr 26, 2023
c83d145
Merge branch 'main' into dependabot/npm_and_yarn/react-moveable-0.49.2
swissspidy Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 23 additions & 27 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/moveable/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@googleforcreators/react": "*",
"@types/styled-components": "^5.1.26",
"prop-types": "^15.7.2",
"react-moveable": "^0.39.3",
"react-moveable": "^0.49.2",
"styled-components": "^5.3.9"
},
"devDependencies": {}
Expand Down
2 changes: 1 addition & 1 deletion packages/story-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,6 @@
"libheif-js": "^1.15.1",
"mockdate": "^3.0.5",
"react": "^17.0.2",
"react-moveable": "^0.39.3"
"react-moveable": "^0.49.2"
}
}
4 changes: 3 additions & 1 deletion packages/story-editor/src/components/canvas/multiSelectionMoveable/useDrag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ function useMultiSelectionDrag({
nodesById[id].contains(inputEvent.target)
);
if (clickedElement) {
handleSelectElement(clickedElement, inputEvent);
setTimeout(() => {
handleSelectElement(clickedElement, inputEvent);
}, 0);
}
// Click was handled.
return true;
Expand Down
2 changes: 1 addition & 1 deletion patches/react-moveable+0.39.6.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ index e7706fd..a28c4ab 100644
+import { IObject } from "@daybrush/utils";
import { Able } from "./types";
import { InitialMoveable } from "./InitialMoveable";
-export declare function makeMoveable<T = {}>(ables: Array<Able<T>>): typeof InitialMoveable & (new (...args: any[]) => InitialMoveable<T>);
-export declare function makeMoveable<T extends Record<string, any> = {}>(ables: Array<Able<T>>): typeof InitialMoveable & (new (...args: any[]) => InitialMoveable<T>);
+export declare function makeMoveable<T extends IObject<any> = {}>(ables: Array<Able<T>>): typeof InitialMoveable & (new (...args: any[]) => InitialMoveable<T>);