New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcode: Fix issue when no attributes are passed #13264
Shortcode: Fix issue when no attributes are passed #13264
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…asanwala/web-stories-wp into fix/shortcode-attr-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Context
This PR fixes #13262 by adding initialization check for the attributes as described in the issue.
Summary
When no argument is passed to the shortcode raises following error:
As per the issue #13262, I have addressed changes mentioned and tested it.
TODO
Testing Instructions
[web_stories /]
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Fixes #13262