Fix formatting keyboard shortcuts on non-text elements #13299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuragVasanwala
added
Type: Bug
|
Plugin builds for a2a96e8 are ready 🛎️!
|
|
Size Change: -15 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
|
Nice find! 😅 Looking at this const hasText = selectedElements.find(({ type }) => type === 'text');What do you think? |
Yes, that would be great! I am updating accordingly into the new commit. But I'm facing an issue in unit-test after I have added brackets: I am looking into unit-test for the component. Any suggestion? |
|
Looks like the dummy text element used in the tests is missing Fixing that makes the tests pass |
If attribute `type: 'text'` does not present it will `hasText()` will return `false` and following three dependent test will fails: - should set the text bold when the key command is pressed - should set the text underline when the key command is pressed - should set the text italics when the key command is pressed Co-Authored-By: Pascal Birchler <pascal.birchler@gmail.com>
Co-Authored-By: Pascal Birchler <pascal.birchler@gmail.com>
Thank you so much 👍🏻 |
swissspidy
changed the title
hasText()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The goal of the PR is to fix #13281.
Summary
Editor crashes when using a keyboard shortcut not applicable to a shape element. For example, enter
cmd+b,cmd+iorcmd+uon a shape element.This is happening because call to a callback function
hasTexthas missing round brackets.hasTextis never executed and following code-block never executes:web-stories-wp/packages/story-editor/src/components/panels/design/textStyle/useRichTextFormatting.js
Lines 189 to 191 in 258b77e
So, it do not return when text is not present.
Relevant Technical Choices
To-do
Fixed with: 2ea1c81
User-facing changes
Not applicable.
Testing Instructions
This PR can be tested by following these steps:
Reviews
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Not applicable.
Fixes #13281