Fixes element measuring relative to fullbleed (better) #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
============================================
+ Coverage 61.93% 61.94% +0.01%
Complexity 216 216
============================================
Files 571 571
Lines 9191 9195 +4
============================================
+ Hits 5692 5696 +4
Misses 3499 3499
|
|
Size Change: +212 B (0%) Total Size: 853 kB
ℹ️ View Unchanged
|
dvoytenko
suggested changes
May 5, 2020
assets/src/edit-story/components/canvas/canvasElementDropzone.js
Outdated
Show resolved
Hide resolved
|
@dvoytenko ready :) |
dvoytenko
approved these changes
May 12, 2020
obetomuniz
added a commit
that referenced
this pull request
May 13, 2020
* master: (99 commits) Bump eslint-plugin-react from 7.19.0 to 7.20.0 (#1749) Checked if date is moment before wrapping Refactored formatted date tests Add spy to standardize timing on tests Remove tests that used to work in CI but no longer do Remove unused import Fix snapshot test for useTemplateAPI Added support for modal-routing on dashboard. Add additional sorting value to ensure the same order. (#1737) update tests around reshaping story object [ImgBot] Optimize images (#1723) Bump @testing-library/dom from 7.5.1 to 7.5.2 (#1732) Fixes element measuring relative to fullbleed (better) (#1558) swapping to use the decoded html version of the title we have access to to turn html symbols from & to characters & adding check for user name to display author moving required for users prop type to component level so that we can reuse the shape without it being required. updating displayDate propType to object not string some organization of imports moving date formatting to the card title level and memoizing clean up translation for modified date string in card item no need to call edit function inline - this has no functional difference but still ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1545