Slight improvements to e2e test setup #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
swissspidy
added
the
Type: Infrastructure
This comment has been minimized.
This comment has been minimized.
swissspidy
commented
May 5, 2020
dvoytenko
reviewed
May 5, 2020
swissspidy
force-pushed
the
add/e2e-tests
branch
2 times, most recently
from
bc80957
to
7a475a0
Compare
swissspidy
changed the title
|
@dvoytenko Any objections to merging this? Helps me with improving the docs around testing (#1476). |
|
Hmm Firefox currently seems to be hanging at the end due to |
swissspidy
force-pushed
the
add/e2e-tests
branch
2 times, most recently
from
44ad9a8
to
9cbc89f
Compare
dvoytenko
reviewed
May 6, 2020
There was a problem hiding this comment.
Hmm Firefox currently seems to be hanging at the end due to
usePreventWindowUnload, despite us usingenablePageDialogAcceptinbeforeAll(which doespage.on('dialog', (dialog) => dialog.accept())
Those will be disablable with #1176
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1476 for docs.
This PR mainly adds some fixtures and bug fixes to the e2e tests.