Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved element drag and drop UI #170

Merged
merged 10 commits into from
Jan 31, 2020
Merged

Improved element drag and drop UI #170

merged 10 commits into from
Jan 31, 2020

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Jan 31, 2020 •
edited
Loading

Partial for #95

Changes

  • Adds snap guidelines (bounds and center of the screen as well as neighbor element guidelines)

Screen Shot 2020-01-30 at 11 22 56 PM

  • Improves UI for the drag and drop handles (follows UI mocks)

Screen Shot 2020-01-30 at 11 17 14 PM

  • Improves UI for the cropping tool (follows UI mocks)

Screen Shot 2020-01-30 at 11 17 38 PM

- Prevents controls from being shown while dragging

@swissspidy
Copy link
Collaborator

swissspidy commented Jan 31, 2020 •
edited
Loading

Improves UI for the cropping tool (follows UI mocks)

Looks like the styling for the range slider there and the one in the grid view is identical. We should extract those to a common component that is shared between the two. (can be in a separate PR of course)

@dvoytenko
Copy link
Contributor

Looks like the styling for the range slider there and the one in the grid view is identical. We should extract those to a common component that is shared between the two. (can be in a separate PR of course)

Agree that should be a separate PR since we're focusing on Moveable here.

dvoytenko
dvoytenko suggested changes Jan 31, 2020
View reviewed changes
assets/src/edit-story/components/canvas/singleSelectionMovable.js Outdated Show resolved Hide resolved
assets/src/edit-story/components/canvas/singleSelectionMovable.js Outdated Show resolved Hide resolved
assets/src/edit-story/components/canvas/singleSelectionMovable.js Outdated Show resolved Hide resolved
assets/src/edit-story/components/canvas/singleSelectionMovable.js Show resolved Hide resolved
assets/src/edit-story/components/canvas/singleSelectionMovable.js Outdated Show resolved Hide resolved
assets/src/edit-story/components/movable/moveStyle.js Show resolved Hide resolved
assets/src/edit-story/elements/image/scalePanel.js Outdated Show resolved Hide resolved
assets/src/edit-story/elements/image/scalePanel.js Show resolved Hide resolved
assets/src/edit-story/elements/image/scalePanel.js Outdated Show resolved Hide resolved
dvoytenko
dvoytenko approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@dvoytenko dvoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one request.

assets/src/edit-story/components/canvas/multiSelectionMovable.js Show resolved Hide resolved
@wassgha wassgha merged commit 18f78f8 into master Jan 31, 2020
@wassgha wassgha deleted the guidelines branch January 31, 2020 23:30
@wassgha wassgha mentioned this pull request Feb 3, 2020
Closed
@swissspidy swissspidy mentioned this pull request Feb 11, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy left review comments

@dvoytenko dvoytenko dvoytenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wassgha @swissspidy @dvoytenko @googlebot